Skip to content

Fix disco filters #2 #50061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 10, 2019
Merged

Fix disco filters #2 #50061

merged 7 commits into from
Nov 10, 2019

Conversation

@lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 6, 2019 •
edited by lukeelmers
Loading

Summary

closes #44349

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 v7.3.0 v7.4.0 v7.5.0 Feature:NP Migration v7.6.0 labels Nov 6, 2019
@lizozom lizozom requested a review from a team as a code owner November 6, 2019 16:59
@lizozom lizozom self-assigned this Nov 6, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 6, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 6, 2019

💚 Build Succeeded

kertal
kertal approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested in Firefox, no more disco filters 🕺

ppisljar
ppisljar approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 8, 2019

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 9, 2019

retest

@lizozom
Copy link
Contributor Author

lizozom commented Nov 10, 2019

@elasticmachine merge upstream

@lizozom
Copy link
Contributor Author

lizozom commented Nov 10, 2019

retest

@lizozom
Copy link
Contributor Author

lizozom commented Nov 10, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 10, 2019

💚 Build Succeeded

@lizozom lizozom merged commit 29aeec8 into elastic:master Nov 10, 2019
@lizozom lizozom mentioned this pull request Nov 10, 2019
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 10, 2019
Fix disco filters #2 (elastic#50061)
2b0f565 
* closes elastic#44349, as well as SDH issue elastic#64

* added tests to cover fix

* eslint

* Fixed test import
This was referenced Nov 10, 2019
Merged
Merged
Closed
lizozom pushed a commit that referenced this pull request Nov 10, 2019
Fix disco filters #2 (#50061) (#50121)
6c03dd2 
* closes #44349, as well as SDH issue #64

* added tests to cover fix

* eslint

* Fixed test import
lizozom pushed a commit that referenced this pull request Nov 11, 2019
[7.4] Fix disco filters #2 (#50061) (#50123)
74b845d 
* backport disco-filters

* add await
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

@lizozom lizozom deleted the bug/disco-filters-2 branch November 14, 2019 13:03
@lizozom lizozom restored the bug/disco-filters-2 branch November 14, 2019 13:03
@lizozom lizozom deleted the bug/disco-filters-2 branch November 14, 2019 13:03
@lizozom lizozom removed the v7.3.2 label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal approved these changes

@ppisljar ppisljar ppisljar approved these changes

@streamich streamich Awaiting requested review from streamich

Assignees

@lizozom lizozom

Labels

bug Fixes for quality problems that affect the customer experience Feature:NP Migration release_note:fix v7.4.3 v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firefox filters are being re-ordered.

4 participants

@lizozom @elasticmachine @kertal @ppisljar