-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#2124) Add ability to initialize without logging #2295
Conversation
b0c89b1
to
9701beb
Compare
9701beb
to
f65b9be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@AdmiringWorm any thoughts on why this is failing the ubuntu build? |
Seems the nuget restore failed there with SSL issues, similar results for all dependent packages:
|
@vexx32 yip, saw the same thing, and was just pinging @AdmiringWorm about it on Slack 😄 |
@vexx32 @AdmiringWorm I have opened a PR attempting to address this here: #2314 Can you both have a review, and let me know what you think? Thanks! |
This commit makes changes to the API initialization method to allow Chocolatey to allow the initialization to happen without enabling logging. Additionally changes have been made to allow adding extra loggers to be added without overriding the logging to the applications main chocolatey.log file. These changes were necessary to allow programs (like ChocolateyGUI) to add its own logging infrastructure without disabling logging to the main log file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.
These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
fixes #2124