Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API - Allow Lets.GetChocolatey to not initialize logging #2124

Closed
ferventcoder opened this issue Sep 25, 2020 · 0 comments · Fixed by #2295
Closed

API - Allow Lets.GetChocolatey to not initialize logging #2124

ferventcoder opened this issue Sep 25, 2020 · 0 comments · Fixed by #2295
Assignees
@ferventcoder
Labels
5 - Released API Improvement
Milestone
0.11.0

Comments

@ferventcoder
Copy link
Member

In some cases you want to call Lets.GetChocolatey without initializing logging (or making any changes to how it might currently be set).
@ferventcoder ferventcoder added this to the 0.10.16 milestone Sep 25, 2020
@ferventcoder ferventcoder self-assigned this Sep 25, 2020
@ferventcoder ferventcoder changed the title API - Allow not initializing logging API - Allow Lets.GetChocolatey to not initialize logging Sep 25, 2020
@pauby pauby modified the milestones: 0.10.16, 0.10.x May 11, 2021
@gep13 gep13 modified the milestones: 0.10.16, 0.10.x May 17, 2021
@AdmiringWorm AdmiringWorm mentioned this issue Jun 21, 2021
Merged
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jun 21, 2021
@AdmiringWorm
(chocolatey#2124) Add ability to initialize without logging
b0c89b1 
This commit makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.

These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jun 21, 2021
@AdmiringWorm
(chocolatey#2124) Add ability to initialize without logging
9701beb 
This commit makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.

These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jun 23, 2021
@AdmiringWorm
(chocolatey#2124) Add ability to initialize without logging
f65b9be 
This commit makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.

These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
@gep13 gep13 modified the milestones: 0.10.x, 0.10.16 Aug 9, 2021
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue Aug 9, 2021
@AdmiringWorm @gep13
(chocolatey#2124) Add ability to initialize without logging
356a830 
This commit makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.

These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue Aug 9, 2021
@AdmiringWorm @gep13
(chocolatey#2124) Add ability to initialize without logging
6200664 
This commit makes changes to the API initialization method to allow
Chocolatey to allow the initialization to happen without enabling
logging.
Additionally changes have been made to allow adding extra loggers to be
added without overriding the logging
to the applications main chocolatey.log file.

These changes were necessary to allow programs (like ChocolateyGUI)
to add its own logging infrastructure without disabling logging
to the main log file.
gep13 added a commit that referenced this issue Aug 9, 2021
@gep13
Merge pull request #2295 from AdmiringWorm/logging-append
6feee97 
(#2124) Add ability to initialize without logging
@gep13 gep13 closed this as completed Aug 9, 2021
@gep13 gep13 added the 4 - Done label Aug 9, 2021
gep13 added a commit that referenced this issue Aug 19, 2021
@gep13
Merge branch 'stable'
c967779 
* stable:
  (maint) Remove unnecessary whitespace
  (#2304) Fix list --exact -a for prereleases
  (#2124) Add ability to initialize without logging
  (#2313) Add argument to call to NuGet.exe
  (doc) fix typo in Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released API Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

(#2124) Add ability to initialize without logging AdmiringWorm/choco
3 participants
@ferventcoder @gep13 @pauby