Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-579) include compiled modules in Boxstarter.zip #580

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mwallner
Copy link
Member

Description Of Changes

The Boxstarter.zip file that is used for remoting scenarios should include the actual (compiled) modules, not the sourcecode (and non-funcitoning psm1 files).

Motivation and Context

This has been missed in GH-565 / GH-563 and therefore needs to be fixed prior to release.

Testing

  1. Invoke-Psake ./BuildScripts/default.ps1 -taskList Package
  2. inspect buildArtifacts/Boxstarter.<version>.zip

Operating Systems Testing

  • Windows 10 1809 LTSC, Windows PowerShell
  • Manjaro Linux, pwsh 7.4

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #579

@mwallner mwallner requested a review from pauby September 16, 2024 18:40
@pauby
Copy link
Member

pauby commented Sep 16, 2024

I think @flcdrg would be in a better position to review this.

@pauby pauby requested review from flcdrg and removed request for pauby September 16, 2024 20:22
@flcdrg
Copy link
Member

flcdrg commented Sep 26, 2024

Sorry for the delay.. must have missed the notification

@mwallner mwallner merged commit 452ab61 into chocolatey:develop Sep 27, 2024
21 checks passed
@mwallner mwallner deleted the GH-579-boxstarterzip branch September 27, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxstarter.zip for remote setup doesn't contain compiled modules
3 participants