Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge individual function scripts into a PowerShell module file #563

Closed
2 tasks done
pauby opened this issue May 13, 2024 · 4 comments · Fixed by #565
Closed
2 tasks done

Merge individual function scripts into a PowerShell module file #563

pauby opened this issue May 13, 2024 · 4 comments · Fixed by #565
Labels
2 - Working A user or team member has started working on the issue TaskItem Non-bug, non-feature related things. Could be refactoring. Sometimes non-code related things.

Comments

@pauby
Copy link
Member

pauby commented May 13, 2024 •
edited
Loading

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

The PowerShell functions are all in their individual scripts (.ps1) and are dot sourced into the PowerShell module file (.psm1). This is not recommended practice and means the scripts are individually signed.

Describe The Solution. Why is it needed?

It is recommended best practice to merge these individual script files into one PowerShell module file at build time, and ship that.

Additional Context

N/A

Related Issues

N/A
@pauby pauby added the TaskItem Non-bug, non-feature related things. Could be refactoring. Sometimes non-code related things. label May 13, 2024
@mwallner
Copy link
Member

I'd propose to use Sampler for this

@pauby
Copy link
Member Author

pauby commented Jun 12, 2024 •
edited
Loading

Can a simple, few lines of code, appending the functions into a file not be a simpler, and less reliant on external 3rd parties, option?

@mwallner
Copy link
Member

Most likely, is there an oss code sample you could point me to as a reference?

@pauby
Copy link
Member Author

pauby commented Jun 14, 2024

There is some code over in PowerShellBuild that would help.

mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 27, 2024
@mwallner
(chocolateyGH-563) build on Linux, prepare script concatenation
df33052
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 27, 2024
@mwallner
(chocolateyGH-563) fix problems reported by vscode extension
01e16c6
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 27, 2024
@mwallner
(chocolateyGH-563) concatenate ps1 into psm1
dee2bee
@mwallner mwallner mentioned this issue Jun 27, 2024
Merged
10 tasks
@mwallner mwallner added the 2 - Working A user or team member has started working on the issue label Jun 27, 2024
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 28, 2024
@mwallner
(chocolateyGH-563) move module exports to manifests
c496476
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 28, 2024
@mwallner
(chocolateyGH-563) bump version in files to 3.1+
9c70ef7
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 28, 2024
@mwallner
(chocolateyGH-563) compoter says no
9d6a72c
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 28, 2024
@mwallner
(chocolateyGH-563) fix parameter for out-file
9691de9
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) build on Linux, prepare script concatenation
d03863f
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) fix problems reported by vscode extension
eec1d42
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) concatenate ps1 into psm1
60d9d16
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) move module exports to manifests
10fbdb9
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) bump version in files to 3.1+
3088b50
flcdrg pushed a commit to mwallner/boxstarter that referenced this issue Jun 29, 2024
@mwallner @flcdrg
(chocolateyGH-563) fix parameter for out-file
4a1fafb
flcdrg added a commit that referenced this issue Jun 30, 2024
@flcdrg
Merge pull request #565 from mwallner/Task-BuildCleanup
7be2ca1 
(GH-563) Merge PowerShell Scripts into shippable Modules on build
This was referenced Sep 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - Working A user or team member has started working on the issue TaskItem Non-bug, non-feature related things. Could be refactoring. Sometimes non-code related things.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-563) Merge PowerShell Scripts into shippable Modules on build mwallner/boxstarter
2 participants
@mwallner @pauby