Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install button is not disabled when installation of packages is not allowed #911

Closed
AdmiringWorm opened this issue Jan 31, 2022 · 1 comment · Fixed by #910
Closed

Install button is not disabled when installation of packages is not allowed #911

AdmiringWorm opened this issue Jan 31, 2022 · 1 comment · Fixed by #910
Assignees
@AdmiringWorm
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
0.20.0

Comments

@AdmiringWorm
Copy link
Member

What You Are Seeing?

When the allowed commands do not include the install command, and we are running through Chocolatey GUI is not launched as an administrator and the chocolateygui.extension is installed, the installation button is not disabled when it is supposed to (unlike the uninstall and the reinstall buttons) on the package details page.

What is Expected?

The install button should be greyed out if the user can not use the command in question.

How Did You Get This To Happen? (Steps to Reproduce)

  1. Set the configuration value backgroundServiceAllowedCommands to not include the command install
  2. Enable background services
  3. Launch Chocolatey GUI (with extension installed) on a non-admin account.
  4. Navigate to one of the source and go to the details page for a package that is not installed.
  5. Notice the Install button can still be clicked.

image

Additional note, the context menu is however still disabled as expected:

image

System Details

  • OS Build (In PowerShell run [System.Environment]::OSVersion.version.tostring()): 10.0.19043.0
  • Windows PowerShell version (Run: $PSVersionTable): 5.1.19041.1320
  • Chocolatey version (Run choco --version): 0.12.1
  • Chocolatey GUI version: 0.19.0

Output Log

Not relevant as it is only a viewable change in the UI, not necessarily in the functionality.
@AdmiringWorm AdmiringWorm added the Bug Issues where something has happened which was not expected or intended label Jan 31, 2022
@AdmiringWorm AdmiringWorm self-assigned this Jan 31, 2022
@AdmiringWorm AdmiringWorm added the 2 - Working A user or team member has started working on the issue label Jan 31, 2022
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Feb 1, 2022
@AdmiringWorm
(chocolatey#911) Add missing disabling of install buttons
f8773fc 
This commit updates both the install and the advanced install
buttons to be disabled if the user running the application are
not allowed to install any backages (only relevant when a
Chocolatey licensed and Chocolatey GUI licensed extensions
are installed).
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Feb 1, 2022
@gep13 gep13 added this to the 0.20.0 milestone Feb 1, 2022
@gep13 gep13 linked a pull request Feb 1, 2022 that will close this issue
(#545) Update to better support advanced installation #910
Merged
9 tasks
@gep13 gep13 closed this as completed in #910 Feb 1, 2022
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Feb 1, 2022
gep13 added a commit that referenced this issue Feb 10, 2022
@gep13
Merge branch 'release/0.20.0'
803556b 
* release/0.20.0: (76 commits)
  (#841) Add assembly to correct nuget folder
  (#533) Handle null culture
  (maint) Fix formatting
  (#533) Allowing setting language during install
  (#545) Remove NumberOfPackageVersionsForSelection
  (#911) Add missing disabling of install buttons
  (#545) Add missing tooltip on disabled install button
  (maint) Cleanup trailing spaces and xmlns statements
  (maint) Remove unused using statements
  (#545) Disable certain values when other features is toggled
  (#533) Set current culture for WPF elements
  (#533) Fix remote sources being reloaded on language change
  (#545) Mark dialog as being open when child window is opened/closed
  (#545) Make version editable on advanced install
  (#545) Add future support for log file argument
  (maint) Remove format support for install configuration description
  (#545) Add missing entry for cache location
  (maint) Add missing description of UseLanguage config
  (#770) Hide button for displaying arguments
  (#770) Show additional message on no arguments
  ...
@gep13
Copy link
Member

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

(#545) Update to better support advanced installation AdmiringWorm/ChocolateyGUI
3 participants
@gep13 @AdmiringWorm @corbob