Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change target .NET Framework version to be 4.8 #841

Closed
gep13 opened this issue Apr 12, 2021 · 1 comment
Closed

Change target .NET Framework version to be 4.8 #841

gep13 opened this issue Apr 12, 2021 · 1 comment
Labels
5 - Released The issue has been resolved, and released to the public for consumption BreakingChange The issue will introduce backwards incompatible changes
Milestone
0.20.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 12, 2021

Based on discussions, we are going to move forward with supporting .NET Framework 4.8, rather than the current .NET Framework 4.5.2. This will open up the potential for doing things like high DPI support.

This will require changing the dependency in the nuspec file to match the required .NET Framework package.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 12, 2021
@gep13 gep13 added this to the 0.19.0 milestone Apr 12, 2021
@gep13 gep13 mentioned this issue Apr 12, 2021
Closed
gep13 added a commit that referenced this issue Apr 13, 2021
@gep13
(#841) Change .NET Framework target to be 4.8
ca0db1b 
This will allow us to add new functionality that has been requested in
Chocolatey GUI, for example, support for high DPI.
@gep13 gep13 mentioned this issue Apr 13, 2021
Closed
@gep13 gep13 closed this as completed Apr 13, 2021
gep13 added a commit that referenced this issue Apr 13, 2021
@gep13
(#836) Add PerMonitor settings to app.manifest
11adbc1 
This should allow the support for Per-Monitor support for high DPI. In
order for this to work, we had to first move to a higher version of .NET
Framework, and also to reference the higher framework version of
MahApps.  Both of these were taken care of in this issue:

#841
@robertheadley robertheadley mentioned this issue Apr 28, 2021
Closed
@AdmiringWorm AdmiringWorm added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jan 21, 2022
@gep13 gep13 added BreakingChange The issue will introduce backwards incompatible changes and removed Improvement Issues that enhances existing functionality, or adds new features labels Feb 8, 2022
gep13 added a commit that referenced this issue Feb 9, 2022
@gep13
(#841) Add assembly to correct nuget folder
d8de455 
Since the assemblies are now building against .NET Framework 4.8, we
should place them into the correct NuGet folder.
gep13 added a commit that referenced this issue Feb 10, 2022
@gep13
Merge branch 'release/0.20.0'
803556b 
* release/0.20.0: (76 commits)
  (#841) Add assembly to correct nuget folder
  (#533) Handle null culture
  (maint) Fix formatting
  (#533) Allowing setting language during install
  (#545) Remove NumberOfPackageVersionsForSelection
  (#911) Add missing disabling of install buttons
  (#545) Add missing tooltip on disabled install button
  (maint) Cleanup trailing spaces and xmlns statements
  (maint) Remove unused using statements
  (#545) Disable certain values when other features is toggled
  (#533) Set current culture for WPF elements
  (#533) Fix remote sources being reloaded on language change
  (#545) Mark dialog as being open when child window is opened/closed
  (#545) Make version editable on advanced install
  (#545) Add future support for log file argument
  (maint) Remove format support for install configuration description
  (#545) Add missing entry for cache location
  (maint) Add missing description of UseLanguage config
  (#770) Hide button for displaying arguments
  (#770) Show additional message on no arguments
  ...
gep13 added a commit that referenced this issue Feb 10, 2022
@gep13
Merge branch 'release/0.20.0' into develop
ab60524 
* release/0.20.0:
  (#841) Add assembly to correct nuget folder
  (#533) Handle null culture
@gep13
Copy link
Member Author

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption BreakingChange The issue will introduce backwards incompatible changes
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
3 participants
@gep13 @AdmiringWorm @corbob