Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to refresh cached icons for packages when there are known changes to icon #624

Closed
hahaki opened this issue Oct 24, 2018 · 5 comments
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone

Comments

@hahaki
Copy link

hahaki commented Oct 24, 2018

I have nexus 3.14 (latest version) storing nupkg / exe and icons for chocolatey packages. At the first time the new package appear in Nexus nuget repo Chocolatey Gui stores the image in data.db in User's home directory. In nuspec file it has a url to nexus as a reference for an icon in chocolatey which works fine at the beginning. If i change the icon (delete old on from Nexus and upload a new one) chocolatey gui does not recognise the change and use the old icon. If i just simply delete the icon from Nexus, chocolatey gui still shows the old one. Restart of chocolatey gui does not solve the issue. Only delete of data.db file forces chocolatey to check the icons a download them again.
Desired functionality: at least for refresh button or/and restart chocolatey gui the icons should be checked if they are obsolete or not and data.db should be updated. If it looks not fast enough md5 checksum can be used for that comparison, Nexus supports that.

(chocolatey Gui version 0.16, choco version 0.10.11, windows 7 sp 1)

@gep13 gep13 added this to the 0.17.0 milestone May 3, 2019
@gep13 gep13 added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label May 3, 2019
@gep13
Copy link
Member

gep13 commented May 3, 2019

@punker76 @pascalberger @mwallner I am going to take a stab at adding this functionality, as I also want the ability to purge the Outdated Packages cache which was added here: #669 but I am not clear on "where" these new buttons (assuming that they are surfaced as buttons) should appear.

I don't think these global actions should appear here:

image

As they are not specific to one particular source. Instead, I was thinking about putting them here:

image

In the new Chocolatey GUI tab in the setting screen, along the bottom of that screen. Perhaps using similar button styles to those shown on the Package Details screen:

image

What are your thoughts?

@punker76
Copy link
Member

punker76 commented May 3, 2019

I don't think these global actions should appear here:

As they are not specific to one particular source. Instead, I was thinking about putting them here:

In the new Chocolatey GUI tab in the setting screen, along the bottom of that screen. Perhaps using similar button styles to those shown on the Package Details screen:

What are your thoughts?

@gep13 I think using the same "button command bar" at the bottom is a good idea. If something like this can always be found in the same place, then users will find it easier to find their way around.

@gep13
Copy link
Member

gep13 commented May 3, 2019

@punker76 sounds like we are on the same page 😄

Thoughts...

image

@gep13
Copy link
Member

gep13 commented May 3, 2019

@punker76 ooo, starting to come together now...

image

All localized, ready for translations 😄

gep13 added a commit that referenced this issue May 3, 2019
There are lots of reason that the end user might want to do this.  This
action now makes this possible.  User will be prompted whether they
actually want to continue before anything is removed.
@gep13 gep13 closed this as completed May 3, 2019
@gep13 gep13 changed the title Icons stored as a cache in data.db does not get a refresh if icon changed on nexus repository Provide ability to refresh cached icons for packages when there are known changes to icon Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants