Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Set explicit PlatformTarget for console #56

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Nov 28, 2024

Description Of Changes

Due to a change in the .NET 9 framework that is being used when running
the Cake Build script, we started having failures due to a missing
target framework.

This was found to be easily fixed by setting the PlatformTarget to
AnyCPU explicitly.

Motivation and Context

To keep the GHA builds running.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build changes

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@AdmiringWorm AdmiringWorm self-assigned this Nov 28, 2024
Due to a change in the .NET 9 framework that is being used when running
the Cake Build script, we started having failures due to a missing
target framework.

This was found to be easily fixed by setting the PlatformTarget to
AnyCPU explicitly.
@AdmiringWorm AdmiringWorm changed the title (maint) Restrict .NET version used for building (maint) Set explicit PlatformTarget for console Nov 28, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 November 28, 2024 11:56
@AdmiringWorm AdmiringWorm marked this pull request as ready for review November 28, 2024 11:56
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 9a415a6 into chocolatey-community:develop Dec 5, 2024
1 check passed
@gep13
Copy link
Member

gep13 commented Dec 5, 2024

@AdmiringWorm thanks for getting this fixed up!

@AdmiringWorm AdmiringWorm deleted the gha-build-fix branch December 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants