Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#37) Implement note rule CPMR0068 #55

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Nov 28, 2024

Description Of Changes

This implements the note rule CPMR0068 that verifies whether the owners
field matches the authors field or not.

This is equivalent to what is implemented in Package Validator, and
should be enhanced in the future.

Motivation and Context

To include as many rules as we can that is implemented by Package Validator.

Testing

  1. Create a nuspec file.
  2. Update the authors and owners element to have the same value.
  3. Run choco pack on the created nuspec file.
  4. Verify the rule CPMR0068 is flagged.
  5. Change the value in the owners element to something else.
  6. Run choco pack on the same nuspec file.
  7. Verify the rule CPMR0068 is NOT flagged

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #37

@AdmiringWorm AdmiringWorm self-assigned this Nov 28, 2024
@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Nov 28, 2024

It is expected that the GHA build will fail, verify with the internal build instead.

EDIT:

PR #56 should be merged before this one

This implements the note rule CPMR0068 that verifies whether the owners
field matches the authors field or not.

This is equivalent to what is implemented in Package Validator, and
should be enhanced in the future.
@gep13
Copy link
Member

gep13 commented Dec 5, 2024

@AdmiringWorm can you please update the testing steps here? They don't seem to reflect what is actually being implemented within this PR. Could they be a copy/paste from the last PR?

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and can be merged, but the test steps need to be updated to match what should actually be tested before we can merge.

@AdmiringWorm
Copy link
Member Author

@AdmiringWorm can you please update the testing steps here? They don't seem to reflect what is actually being implemented within this PR. Could they be a copy/paste from the last PR?

I have updated the testing steps now. And yes, you are right with it being a copy/paste from the last PR.

@gep13 gep13 merged commit a25dd20 into chocolatey-community:develop Dec 5, 2024
1 check passed
@gep13
Copy link
Member

gep13 commented Dec 5, 2024

@AdmiringWorm thanks for getting that updated, and for getting this new rule added!

@AdmiringWorm AdmiringWorm deleted the issue37 branch December 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement note rule CPMR0068 - Author Does Not Match Maintainer
2 participants