New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: line-length rule ignores comments #941

Open

tgorochowik opened this issue Sep 23, 2021 · 0 comments

Labels

Member

tgorochowik commented Sep 23, 2021

See: lowRISC/ibex#1434 (comment)

The line length rule ignores comments.
This seems to by design but it certainly is not something users expect.

I see a few ways to deal with this:

leave it as is, but them we should at least update the documentation: https://chipsalliance.github.io/verible/lint.html#line-length
make it take comments into account
make it configurable and agree on what should be the default (I'd vote to find violations on comments too)

tgorochowik added the style-linter label

tgorochowik changed the title ~~linter ignores too long comments~~ linter: line-length rule ignores comments

tgorochowik mentioned this issue

[TEST] Fail the linter lowRISC/ibex#1434

Closed

wsipak mentioned this issue

line length rule: add a parameter to check comments #972

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment