Skip to content

catch None.get in BitPat.apply(x: UInt): BitPat #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 9, 2021
Merged

catch None.get in BitPat.apply(x: UInt): BitPat #2276

merged 4 commits into from
Dec 9, 2021

Conversation

@sequencer
Copy link
Member

@sequencer sequencer commented Dec 2, 2021

Resolves #2268, thanks @Tang-Haojin

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

None

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer requested a review from jackkoenig December 2, 2021 14:20
jackkoenig
jackkoenig reviewed Dec 9, 2021
View reviewed changes
@jackkoenig jackkoenig enabled auto-merge (squash) December 9, 2021 00:47
@jackkoenig jackkoenig added this to the 3.3.x milestone Dec 9, 2021
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 9, 2021
jackkoenig
jackkoenig reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is in package chisel3.util, I think a regular require is more appropriate than an internal ChiselException

@jackkoenig jackkoenig disabled auto-merge December 9, 2021 00:58
@jackkoenig jackkoenig enabled auto-merge (squash) December 9, 2021 00:59
@jackkoenig jackkoenig merged commit 849d4a0 into master Dec 9, 2021
@jackkoenig jackkoenig deleted the bitpat_fix branch December 9, 2021 02:25
mergify bot pushed a commit that referenced this pull request Dec 9, 2021
@sequencer
catch None.get in BitPat.apply(x: UInt): BitPat (#2276)
35729ed 
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 849d4a0)

# Conflicts:
#	src/test/scala/chiselTests/util/BitPatSpec.scala
@mergify mergify bot mentioned this pull request Dec 9, 2021
Merged
mergify bot pushed a commit that referenced this pull request Dec 9, 2021
@sequencer
catch None.get in BitPat.apply(x: UInt): BitPat (#2276)
0e60e99 
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 849d4a0)

# Conflicts:
#	src/test/scala/chiselTests/util/BitPatSpec.scala
@mergify mergify bot mentioned this pull request Dec 9, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Dec 9, 2021
mergify bot added a commit that referenced this pull request Dec 9, 2021
@mergify @sequencer @jackkoenig
catch None.get in BitPat.apply(x: UInt): BitPat (backport #2276) (#2295)
c48d234 
* catch None.get in BitPat.apply(x: UInt): BitPat (#2276)

Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 849d4a0)

# Conflicts:
#	src/test/scala/chiselTests/util/BitPatSpec.scala

* Resolve backport conflicts

Remove BitPatSpec since this backport is just a simple require.

Co-authored-by: Jiuyang Liu <[email protected]>
Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Dec 9, 2021
@mergify @sequencer @jackkoenig
catch None.get in BitPat.apply(x: UInt): BitPat (backport #2276) (#2296)
c146fa0 
* catch None.get in BitPat.apply(x: UInt): BitPat (#2276)

Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 849d4a0)

# Conflicts:
#	src/test/scala/chiselTests/util/BitPatSpec.scala

* Resolve backport conflicts

Remove BitPatSpec since this backport is just a simple require.

Co-authored-by: Jiuyang Liu <[email protected]>
Co-authored-by: Jack Koenig <[email protected]>
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@sequencer @jackkoenig @mergify
prefer to using using system protoc and antlr4 in mill (#2276)
765af61 
* If exist protoc in the $PATH, prefer to using it.

* add checkSystemAntlr4Version and checkSystemProtocVersion

* Update build.sc

Co-authored-by: Jack Koenig <[email protected]>

Co-authored-by: Jack Koenig <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees

No one assigned

Labels

Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.

Projects

None yet

Milestone

3.3.x

Development

Successfully merging this pull request may close these issues.

BitPat is not happy with Cat(someEnum.asUInt, someBool.B)

3 participants

@sequencer @jackkoenig