Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

勘误改错字 from animalize #10

Merged
merged 71 commits into from Mar 20, 2018
Merged

勘误改错字 from animalize #10

merged 71 commits into from Mar 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2017

No description provided.

animalize and others added 2 commits July 14, 2017 11:07
@jackeyGao
Copy link
Member

暇 会不会是通假字或者繁体字?

@ghost ghost mentioned this pull request Jul 17, 2017
@ghost
Copy link
Author

ghost commented Jul 17, 2017

查了一下,应该不是通假字和繁体字。

我创建了一个issue。其实不必立刻处理,权当一种记录吧。

@jackeyGao
Copy link
Member

Hi @animalize 感谢提供纠正, 这些争议字的根据是什么? 如果有根据出处供参考就好了 😄

@ghost
Copy link
Author

ghost commented Jul 21, 2017

我是这个流程:

  1. 看诗的时候发现某个字不对劲,进入2。
  2. 查字典,如果字典明确表示有错进入3。
  3. 在百度、谷歌上搜索句子进行确认,往往正误的句子都能找到,这时才进行修改。

您不用管这个pull request,放着就行啦。

@ghost ghost changed the title 错字:暇 改为 瑕 勘误改错字 from animalize Jul 21, 2017
@jackeyGao
Copy link
Member

准备把这个合上去, 本身也是前前朝的著作。 汉字也已经重新修订了, 也是该修下数据了, 后续有争议的话还可以再讨论。

https://github.com/chinese-poetry/chinese-poetry/pull/10/conflicts 我尝试解决这些冲突, 但非常吃力, 所以麻烦你解决下冲突。

再次感谢兄弟的贡献。

@ghost
Copy link
Author

ghost commented Mar 20, 2018

@jackeyGao
好。
我打算把部分唐诗缺句的问题处理一下。

@jackeyGao jackeyGao merged commit d09e560 into chinese-poetry:master Mar 20, 2018
@ghost
Copy link
Author

ghost commented Mar 20, 2018

请暂时revert这个合并,感觉部分冲突处理有误。
抱歉还不太熟练这个。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants