-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Romanian (ro) translate #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm not familiar with Romanian, but it looks like the <plurals>
translations require one for quantity="few"
. Right now, there are only translations for quantity="one"
and quantity="other"
.
/home/runner/work/BCR/BCR/app/src/main/res/values-ro/strings.xml:23: Error: For locale "ro" (Romanian) the following quantity should also be defined: few (e.g. "2 zile") [MissingQuantity]
<plurals name="pref_min_duration_desc">
Thanks for the suggestion. |
Ah, the required items are different depending on the language. Android follows the Unicode rules, which are listed in a (kind of confusing) table here: https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html Romanian requires (French requires |
I have removed the item "many", in accordance with the Unicode rules indicated by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Andrew Gunnerson <[email protected]>
First of all thanks for the app, it is an option for call recording even without root.
I am new to this but want to help to develop the app. I have inserted the translation into the file app/src/main/res/values-ro/strings.xml. I also updated the app/src/main/res/xml/locales_config.xml and app/build.gradle.kts files.
If I got something wrong, let me know.