Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian (ro) translate #613

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Romanian (ro) translate #613

merged 4 commits into from
Oct 18, 2024

Conversation

gilav23
Copy link
Contributor

@gilav23 gilav23 commented Oct 16, 2024

First of all thanks for the app, it is an option for call recording even without root.
I am new to this but want to help to develop the app. I have inserted the translation into the file ‎app/src/main/res/values-ro/strings.xml. I also updated the app/src/main/res/xml/locales_config.xml and app/build.gradle.kts files.
If I got something wrong, let me know.

Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'm not familiar with Romanian, but it looks like the <plurals> translations require one for quantity="few". Right now, there are only translations for quantity="one" and quantity="other".

   /home/runner/work/BCR/BCR/app/src/main/res/values-ro/strings.xml:23: Error: For locale "ro" (Romanian) the following quantity should also be defined: few (e.g. "2 zile") [MissingQuantity]
      <plurals name="pref_min_duration_desc">

@gilav23
Copy link
Contributor Author

gilav23 commented Oct 18, 2024

Thanks for the suggestion.
As I said, I want to translate everything, but I looked at other translations (fr and en), and I didn't find any record with the item "few".
Then I checked other translations where I found the item "few", but only in one string.
Anyway, I updated strings.xml.
A good day.

@chenxiaolong
Copy link
Owner

As I said, I want to translate everything, but I looked at other translations (fr and en), and I didn't find any record with the item "few".

Ah, the required items are different depending on the language. Android follows the Unicode rules, which are listed in a (kind of confusing) table here: https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html

Romanian requires one, few, and other:
image

(French requires one, many, and other, while English only requires one and other.)

@gilav23
Copy link
Contributor Author

gilav23 commented Oct 18, 2024

I have removed the item "many", in accordance with the Unicode rules indicated by you.

Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenxiaolong chenxiaolong merged commit 23a0cbf into chenxiaolong:master Oct 18, 2024
1 check passed
chenxiaolong added a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants