Themed Icon Support

[CodElixer]

Hi Andrew!

It was really great for working together n helping to fix the Audio Overlapping Issue :)

As that major issue has been fixed, I would suggest you some minor enhancement for the app.

1. As currently the BCR doesn't support Themed Icon, You can look into this for future updates.
   I've attached the screenshot, As you can see WhatsApp and other app icons are themed according to the System Theme.
   

2. For me the app hasn't permission for the contact and that's why it wasn't saving contacts name in the recordings. When I provided the permission manually then It was saving the Contacts name with recordings.
   You can mention it in GitHub's Readme.md for manually providing Contacts Permission will record the contacts name in recordings or an option within the app that will specifically ask for the same.

Best Regards,
Yash

[chenxiaolong]

Hmm, I'm not sure what would cause that. BCR has supported themed icons since the first version. It's working for me with the default Pixel launcher: Screenshot_20220614-133402 Does clearing the launcher's cache help at all?

You can mention it in GitHub's Readme.md for manually providing Contacts Permission will record the contacts name in recordings or an option within the app that will specifically ask for the same.

👍 I'll add it to the README for sure and think about whether to add an option to the app. EDIT: Maybe I can make it part of the initial permissions prompt (notifications required, microphone required, contacts optional).

[CodElixer]

Hmm, I'm not sure what would cause that. BCR has supported themed icons since the first version. It's working for me with the default Pixel launcher: Screenshot_20220614-133402 Does clearing the launcher's cache help at all?

Ohh! And I thought it doesn't support because it never themed from the first install. Strange!!

EDIT: Maybe I can make it part of the initial permissions prompt (notifications required, microphone required, contacts optional).

Yeah, That'd be better 👍🏻

[CodElixer]

Tried clearing Cache of the Pixel Launcher but it didn't helped either!

[chenxiaolong]

Oh, I just thought of something: is your ROM based on Android 12 or 13? Themed icon support was officially added to Android in 13, but some ROMs make it work for third party apps on 12 by bundling icons for popular apps into the ROM. I wonder if that's the case here.

[CodElixer]

Oh, I just thought of something: is your ROM based on Android 12 or 13? Themed icon support was officially added to Android in 13, but some ROMs make it work for third party apps on 12 by bundling icons for popular apps into the ROM. I wonder if that's the case here.

Oops, It's Pixel Experience Plus ROM based on Android 12L #39 (comment).

[chenxiaolong]

I've added a section to the README about permissions and also added the contacts permission to the initial permissions prompt. That will be included in version 1.13.