SettingsActivity: Prompt for optional contacts permission on first enable

The contacts permission is used to add the contact name to the output
filenames. The permission prompt will only be shown the first time call
recording is enabled. If the user chooses to not allow the permission,
but wants to allow it later, they will have to do so via the system
settings.

Fixes: #78
Fixes: #80

Signed-off-by: Andrew Gunnerson <[email protected]>

Author: chenxiaolong

app/src/main/java/com/chiller3/bcr/Permissions.kt

@@ -20,6 +20,7 @@ object Permissions {
         }
 
     val REQUIRED: Array<String> = arrayOf(Manifest.permission.RECORD_AUDIO) + NOTIFICATION
+    val OPTIONAL: Array<String> = arrayOf(Manifest.permission.READ_CONTACTS)
 
     private fun isGranted(context: Context, permission: String) =
         ContextCompat.checkSelfPermission(context, permission) == PackageManager.PERMISSION_GRANTED

app/src/main/java/com/chiller3/bcr/SettingsActivity.kt

@@ -42,7 +42,8 @@ class SettingsActivity : AppCompatActivity() {
 
         private val requestPermissionRequired =
             registerForActivityResult(ActivityResultContracts.RequestMultiplePermissions()) { granted ->
-                if (granted.all { it.value }) {
+                // Call recording can still be enabled if optional permissions were not granted
+                if (granted.all { it.key !in Permissions.REQUIRED || it.value }) {
                     prefCallRecording.isChecked = true
                 } else {
                     startActivity(Permissions.getAppInfoIntent(requireContext()))
@@ -174,7 +175,8 @@ class SettingsActivity : AppCompatActivity() {
                 prefCallRecording -> if (Permissions.haveRequired(context)) {
                     return true
                 } else {
-                    requestPermissionRequired.launch(Permissions.REQUIRED)
+                    // Ask for optional permissions the first time only
+                    requestPermissionRequired.launch(Permissions.REQUIRED + Permissions.OPTIONAL)
                 }
                 // This is only reachable if battery optimization is not already inhibited
                 prefInhibitBatteryOpt -> requestInhibitBatteryOpt.launch(