Repository navigation
fix(routing): only let Codex-native bare ids preempt a provider when codex is active - #9447
Merged
diegosouzapw merged 3 commits intoAug 4, 2026
Conversation
…codex is active #9275 widened CODEX_NATIVE_UNPREFIXED_MODELS from a single id to gpt-5.5 plus the gpt-5.6-sol/terra/luna tiers, so bare Codex CLI ids would reach the ChatGPT subscription instead of fanning out to whichever provider won the inference race. The early return it added never consulted the active-provider set, which made the codex-only guard 30 lines below unreachable for every id in the set: if (CODEX_NATIVE_UNPREFIXED_MODELS.has(modelId)) return { provider: "codex", ... } An OpenAI-only install therefore had bare gpt-5.5 routed to codex and failed with 'no active credentials for provider: codex' on a model OpenAI serves, and an install whose codex connection was merely inactive failed identically. This also silently reverted #5887's compatibility boundary. The preference now only PREEMPTS another provider when a codex connection is active. Ids that no other provider catalogs (codex-auto-review) still resolve to codex with no connection at all — there is nothing to preempt and 'no codex credentials' is the honest error. With codex active the preference still beats OpenAI, which is the point of #9275, and an explicit openai/ prefix overrides it either way. Tests: the three assertions that encode the intended #9275 change now expect codex (plus a new one pinning the explicit-prefix override); the rest were already correct and pass again untouched. Adds a regression test for the OpenAI-only case.
… guards The two files #9275 added assert that bare gpt-5.5 / gpt-5.6-sol reach codex, but they ran against an empty database — so they also pinned 'codex wins with no codex connection at all', which is the regression #9447 removes. That put them in direct contradiction with plan3-p0 / chat-helpers / codex-gpt55-routing-5887, which assert openai for the very same input: no implementation could satisfy both, which is why the release could not go green. Seeding an active codex connection keeps the contract these files were written to guard (codex beats openai for a Codex-native bare id) while dropping the accidental 'even with no codex configured' half. Cases that need no connection are left as they were: the tier-only ids and codex-auto-review have no alternative provider to preempt, and the explicit-prefix overrides are unaffected.
This was referenced Aug 4, 2026
diegosouzapw
added a commit
to wgordon17/OmniRoute
that referenced
this pull request
Aug 5, 2026
…#9447 gpt-5.5 contract (owner decision) Keeps this PR's surviving value (the cheaper-inference#9275 comment fixes + the documented cheaper-inference#5887×cheaper-inference#9447 interplay at the preemption site + own-growth baseline entry) and drops the behavioral carve-out: the base's cheaper-inference#9447 active-connection bound already delivers the agreed contract (OpenAI while codex is inactive, active codex preempts, openai/ prefix overrides), encoded in codex-gpt55-routing-5887.test.ts. Inherited file-size bumps reverted (release captain domain; cheaper-inference#9355 base-relative mode protects innocent PRs).
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 13, 2026
…sibling sweep Real production defects fixed (all red on the pure tip, each with its origin): - routeGuard.ts: #8949 accidentally DELETED the /api/providers/[id]/login local-only pattern — the route spawns a browser, so the loopback gate for a process-spawning route was gone (Hard Rules #15/#17); restored (314 guard tests green) - agentSkills generator: #9058's category dispatch gave the config category an empty body, wiping skills/config-codex-cli/SKILL.md at the #10131 sync; fixed + SKILL.md regenerated via the official generator - imageRegistry: #9982 broke same-provider bare aliasing (antigravity preview id sent upstream unresolved); new resolveSameProviderBareAlias() keeps the fal cross-provider fix intact - imageRegistry: #9982's prefix strip handed the bare nano-banana ids to fal-ai, violating the pinned 2026-07-31 operator decision (adobe-firefly owns them); fal entries made prefix-only (dispatch already re-prefixes) - mediaGeneration/fal.ts: the missing-credential 401 guard was lost when #10198 deleted the superseded falHandler — tests were hitting the live network - bottleneckPatch/rateLimitManager: #9041's merge clobbered #9604, resurrecting the Bottleneck v2.19.5 heartbeat bug (reservoir never refills); patched the library defect at the root and re-aligned chat-rate-limit-body-lock to the working reservoir contract - processSupervisor.mjs: #9761 regressed the Node spawn to bare "node" (the #9156 launchd bug) and dropped #9209's ipv4first args; both restored - openai-responses/pureHelpers: #9423's Agent null-sentinel was unreachable on the schemaless JSON-string path; gate extended - i18n en.json: #8222's regen reverted the #9976 unclosed-tag fix and #8559's combo-cooldown copy; #9038 shipped 40 t() calls with no messages (runtime MISSING_MESSAGE); all restored/added + official sync-ui stamps, and vi's zero-marker policy re-established via the sanctioned translation backend Stale sibling tests aligned (movers cited inline): chat-helpers (#9447), executor-antigravity (#9351), video-fal-grok (#9982), visionBridge (#9759), web-session-credentials (#8974), production-build-module-integrity (positive anchor added), agentSkills-generator/skillManifestsLint/skills-injection/ agentSkillTools-mcp/listCapabilities-a2a (#9058), memory-settings (#10010), model-catalog-policy-invalidation (#8906), model-alias-seed (#9485), reactive-context-compaction (#8949), combo-provider-wildcard (broken upsert helper), oauth-google-loopback (43-locale resurrected-key removal) Validation: 501/501 across the 47 touched test files; typecheck:core, lint, file-size, docs-sync all green. Refs #9985
diegosouzapw
added a commit
that referenced
this pull request
Aug 13, 2026
* fix(ci): clear base-reds on release/v3.8.50 (round 3) - CHANGELOG.md: restore the top [Unreleased] section dropped by the #10189 reconcile (docs-sync gate: first section must be Unreleased) - env-doc-sync: document CONDUCTOR_ORCHESTRATOR_TOKEN + CONDUCTOR_SPOKESPERSON_URL in .env.example/ENVIRONMENT.md; allowlist the CI-only GITHUB_STEP_SUMMARY and TS7_BASE_REF (ts7 ratchet signals); drop a stray merge artifact line - providers: restore the audited chatanywhere metadata entry that base-reds round 2 dropped together with its duplicate — the provider was half-wired (registry+endpoint without APIKEY metadata), which is what the wave3 test catches; re-pin providers-constants-split at the measured 228 - docs counts: 338 -> 339 (today's +2 void-ai/helixmind, -1 Puter) via gen:provider-reference + README/AGENTS/llm.txt/package.json/diagrams/i18n mirrors - file-size ratchet: annotated rebaseline for the two pre-existing drifts (ModelSelectModal 1138, gateways 1250) following the 2026-08-11 precedent Refs #9985 * fix(ci): base-reds round 3b — stale sibling tests + mode-pack weight contract - check-docs-counts-sync.test.ts: drop the imports/subtests of the four helpers #10196 removed from the gate script (readMcpFactsFromSource, listLocalizedDocs, makeRequiredCountsValidator, checkFreeTierInventory) — the new-API tests that #10196 added stay; the file now loads again under the node runner - quota-connection-recovery.test.ts: convert from vitest APIs to node:test — the file lives in tests/unit/*.test.ts (node-runner glob) and the vitest runtime crashes when imported outside vitest, killing the whole shard entry - modePacks.ts: re-normalize all six mode packs to sum 1.0 — #8940 added sessionAvailability: 0.05 to every pack without rebalancing (1.05 total); ratios preserved exactly (÷1.05), so post-normalizeScoringWeights behavior is unchanged; restores the declared sum-to-1.0 contract the 4235 test pins Refs #9985 * fix(ci): base-reds round 3c — vitest siblings, weights default, secrets FP, mutation tap - DistributeProxiesButton.test.tsx: wrap renders in NextIntlClientProvider — #9245 localized the component (useTranslations) and left the test without the intl context, failing all 14 cases - scoring.ts: re-normalize DEFAULT_WEIGHTS to sum 1.0 (same #8940 class as the mode packs — sessionAvailability added without rebalancing; ratios preserved) - .gitleaks.toml: generalize the kimi sponsor-banner localStorage-key allowlist to -v\d+ — #10200 bumped v1→v2 and the stale regex regressed the secrets ratchet with a false positive - stryker.conf.json: register 6 covering unit tests in tap.testFiles (4 modules) so their mutant kills count — unblocks check:mutation-test-coverage --strict Refs #9985 * fix(ci): base-reds round 3d — inspector factor gap, stale registry/gap tests, i18n key sync - comboScoringInspector: add cacheAffinity/sessionAvailability/connectionDensity to FACTOR_KEYS + the factor-key type — calculateScore() weighs them but the breakdown omitted them, so the explained contributions never summed to the reported score (inspector bug, red on the pure tip) - combo-scoring-inspector.test: make the explicit-weights override sum-neutral (±0.05 shift) so it stays valid for any DEFAULT_WEIGHTS values — the hardcoded override only summed to 1.0 against the pre-#8940 defaults, which is also why explicit weights silently fell back to 'default' on the tip - unorouter-registry.test: align to the canonical .com host (api.unorouter.ai 301-redirects there, verified live) and to wave4's live model discovery (passthrough, no static seed) — the .ai/auto-model expectations were stale - check-migration-numbering.test: 147 left KNOWN_GAPS when 147_api_keys_model_access_mode.sql landed — assert absent (same as 143) - i18n: sync-ui pass — 35,914 missing UI keys stamped as __MISSING__ placeholders across 42 locales (mechanical; greens the pt-BR key-presence integrity test; coverage pct unchanged by design — translation is a separate workstream) Refs #9985 * fix(ci): base-reds round 3e — 2 real defects + 14 stale sibling tests (waves A-E) Real defects fixed: - src/lib/db/apiKeys.ts: #9313's empty-allowlist early return bypassed the group permission check, silently disabling group deny rules (#8817) for every key without a per-key allowlist; fall-through restored, restricted+[] deny-all kept - open-sse/utils/proxyFetch.ts: #10032 re-appended the raw transport error to the propagated message, reintroducing the proxy user:password leak #9837 closed; new redactProxyDetailsInMessage() keeps the reason, redacts URL/credentials - .github/workflows/quality.yml: #10134 added the TS7 ratchet as a separate blocking step AFTER the aggregated gates — the exact #8542 masking mechanism; folded into the non-fail-fast loop (still blocking, still PR-only)⚠️ CI edit, gate-strengthening — explicit owner sign-off requested on the PR - src/i18n/messages/ko.json: 3 machine-mistranslation regressions caught by the #8244 glossary checker (장애인→비활성화됨, 양말5://→socks5://, 비클로드→Claude가 아닌) Stale sibling tests aligned to deliberately-moved contracts (each cites its mover): request-log-detail-layout + -stream (#9245 intl provider), repro-8542 pin update, quality-rail-gate-membership (#10134 shape), agentSkills-routes 45→46 (#9058), cloudflare-ai-catalog-8717 (#8804 supersedes #8808), executor-xai (#9994), vision-bridge-claude-wire (#9463 minimax→openai), sse-auth forced-pin (#8893), tls-proxy-context (strengthened leak guards), rate-limit-local-error-classification (#9164/#9342), minimax-thinking-signature (#9463), codebuddy-cn (#9723 +1 test), github-copilot-custom-model (#9050), providers-g4f-batch3 (#9584), synced-capability-warmup (#9199, stricter), sidebar-tools-group (#8221), oauth-modal-grok-cli-paste (#9245); agentSkills/catalog.ts comment 45→46; file-size rebaseline for proxyFetch (+19, annotated) Refs #9985 * fix(ci): base-reds round 3f — waves F-J: 9 more real defects + stale sibling sweep Real production defects fixed (all red on the pure tip, each with its origin): - routeGuard.ts: #8949 accidentally DELETED the /api/providers/[id]/login local-only pattern — the route spawns a browser, so the loopback gate for a process-spawning route was gone (Hard Rules #15/#17); restored (314 guard tests green) - agentSkills generator: #9058's category dispatch gave the config category an empty body, wiping skills/config-codex-cli/SKILL.md at the #10131 sync; fixed + SKILL.md regenerated via the official generator - imageRegistry: #9982 broke same-provider bare aliasing (antigravity preview id sent upstream unresolved); new resolveSameProviderBareAlias() keeps the fal cross-provider fix intact - imageRegistry: #9982's prefix strip handed the bare nano-banana ids to fal-ai, violating the pinned 2026-07-31 operator decision (adobe-firefly owns them); fal entries made prefix-only (dispatch already re-prefixes) - mediaGeneration/fal.ts: the missing-credential 401 guard was lost when #10198 deleted the superseded falHandler — tests were hitting the live network - bottleneckPatch/rateLimitManager: #9041's merge clobbered #9604, resurrecting the Bottleneck v2.19.5 heartbeat bug (reservoir never refills); patched the library defect at the root and re-aligned chat-rate-limit-body-lock to the working reservoir contract - processSupervisor.mjs: #9761 regressed the Node spawn to bare "node" (the #9156 launchd bug) and dropped #9209's ipv4first args; both restored - openai-responses/pureHelpers: #9423's Agent null-sentinel was unreachable on the schemaless JSON-string path; gate extended - i18n en.json: #8222's regen reverted the #9976 unclosed-tag fix and #8559's combo-cooldown copy; #9038 shipped 40 t() calls with no messages (runtime MISSING_MESSAGE); all restored/added + official sync-ui stamps, and vi's zero-marker policy re-established via the sanctioned translation backend Stale sibling tests aligned (movers cited inline): chat-helpers (#9447), executor-antigravity (#9351), video-fal-grok (#9982), visionBridge (#9759), web-session-credentials (#8974), production-build-module-integrity (positive anchor added), agentSkills-generator/skillManifestsLint/skills-injection/ agentSkillTools-mcp/listCapabilities-a2a (#9058), memory-settings (#10010), model-catalog-policy-invalidation (#8906), model-alias-seed (#9485), reactive-context-compaction (#8949), combo-provider-wildcard (broken upsert helper), oauth-google-loopback (43-locale resurrected-key removal) Validation: 501/501 across the 47 touched test files; typecheck:core, lint, file-size, docs-sync all green. Refs #9985 * fix(ci): base-reds round 3g — wave K/L: 4 more real defects + stale alignments Real defects: - base/reasoningEffort.ts: the stale duplicate cherry-pick #9612 re-added the codex minimal→low rewrite that #9883 had deliberately removed (OMP minimal passthrough); block removed again - cursorImages.ts: #9840 wired prepareCursorImageForWire (sharp re-encode, fail-closed) into the SHARED resolveCursorImages, breaking zai-web and conol-web image uploads (HTTP 400 'undecodable'); new prepareForWire opt-out, Cursor default path unchanged (8 cursor suites green) - modelCapabilities/snapshot: catalog prepare still issued 323 per-model reads of model_context_overrides + max_input_tokens overrides, violating #9199's bulk-load contract; both now resolve from the snapshot single pass - v1-models-discovery-conformance: re-pinned to the bounded 30s SWR window (#9199/#10198) — the old 'stale-first regardless of age' contract is gone Stale tests aligned (movers cited inline): codex-tools-strict-default (#9828 redundant-oneOf strip), devin-providers (#9245 i18n), db-migrationrunner- constants-split (147→151 renumber #8228), gitlab-duo-oauth-setup (#9245), chatcore-extracted-modules (#9161 outbound-protocol keying) compression-api CI failures were cascade artifacts of codex-tools-strict-default failing in the same force-exit shard process — no own defect (171/171 local). Refs #9985 * fix(test): compression-api — register both describes before the runner starts The DATA_DIR setup + route/db top-level awaits sat BETWEEN the two describes; under --test-force-exit (the CI unit-runner flag) the process exits once the already-registered tests finish, so on slow CI machines the whole second describe died as 'Promise resolution is still pending' — the recurring CI-only shard-2 failure that never reproduced locally without the flag. Moved to the top of the file; 10/10 under --test-force-exit locally. Refs #9985 * fix(quality): freeze modelCapabilities.ts at 1006 (annotated) — snapshot routing growth Refs #9985 * fix(quality): move the modelCapabilities freeze into the frozen map (nested schema) Refs #9985 * fix(i18n): translate all 39,718 pending UI keys across 42 locales (owner-approved) Mass-translated every __MISSING__ placeholder via the official i18n:sync-ui --translate-markers pipeline (operator backend), restoring i18nUiCoverage to the 100 baseline (was 89.9 after the merge-storm UI landings + the 42 keys #9038 never shipped). Post-pass repairs, all caught by the existing gates: - glossary: retired renderings the machine reintroduced normalized again (提供商→提供者 zh-CN/zh-TW, 鏈接→連結, 文檔→文件, 調用→呼叫, 供應商→提供者, 響應→回應, 不活躍→未啟用 zh-TW; 클로드→Claude, 옴니루트→OmniRoute ko); DATA_DIR forbidden rendering avoided via 数据文件夹 rephrase - ICU integrity: 120 values with renamed/dropped {params} repaired (39 positional renames, 81 reset to the en source — functional over fluent) Validation: glossary/pt-BR/vi/deno-relay/settings-keys/value-drift/google- loopback suites 76/76; placeholder diff en×42 locales = 0; worst-locale coverage = 100.0%. Refs #9985 --------- Co-authored-by: backryun <bakryun0718@proton.me>
QuangBlue
pushed a commit
to QuangBlue/OmniRoute
that referenced
this pull request
Sep 24, 2026
CODEX_NATIVE_UNPREFIXED_MODELS lists the Codex model ids that should reach the ChatGPT subscription when a client sends them without a provider prefix (cheaper-inference#9275), bounded to installs with an active Codex connection (cheaper-inference#9447). GPT-6 Astra came to the Codex catalog in cheaper-inference#13026 with the same effort tiers as gpt-5.6-sol/terra, but its ids were never added to the set. With both a Codex and an OpenAI connection active: - bare `gpt-5.6-sol` routed to Codex, bare `gpt-6-astra` routed to OpenAI; - /v1/models listed bare `gpt-5.6-*` ids but no bare `gpt-6-astra*` id. Add gpt-6-astra and its six effort variants. The cheaper-inference#9447 bound still applies: OpenAI's catalog also lists `gpt-6-astra`, so without an active Codex connection the bare id keeps resolving to OpenAI. The effort variants are Codex-family ids (codex and codex-app-server); they already routed to Codex when it was active, so for them only the /v1/models rows change, exactly as for the gpt-5.6 variants. Test: tests/unit/codex-gpt6-astra-bare-id.test.ts (3 of 4 cases fail on the previous model.ts; the fourth pins the no-Codex fallback). Three comments in models-catalog-low-noise-flag.test.ts counted the set's size ("26 of the 27") and one cited its old line range; they now describe the one exception without a count and point at the file only.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…codex is active (cheaper-inference#9447) * fix(routing): only let Codex-native bare ids preempt a provider when codex is active cheaper-inference#9275 widened CODEX_NATIVE_UNPREFIXED_MODELS from a single id to gpt-5.5 plus the gpt-5.6-sol/terra/luna tiers, so bare Codex CLI ids would reach the ChatGPT subscription instead of fanning out to whichever provider won the inference race. The early return it added never consulted the active-provider set, which made the codex-only guard 30 lines below unreachable for every id in the set: if (CODEX_NATIVE_UNPREFIXED_MODELS.has(modelId)) return { provider: "codex", ... } An OpenAI-only install therefore had bare gpt-5.5 routed to codex and failed with 'no active credentials for provider: codex' on a model OpenAI serves, and an install whose codex connection was merely inactive failed identically. This also silently reverted cheaper-inference#5887's compatibility boundary. The preference now only PREEMPTS another provider when a codex connection is active. Ids that no other provider catalogs (codex-auto-review) still resolve to codex with no connection at all — there is nothing to preempt and 'no codex credentials' is the honest error. With codex active the preference still beats OpenAI, which is the point of cheaper-inference#9275, and an explicit openai/ prefix overrides it either way. Tests: the three assertions that encode the intended cheaper-inference#9275 change now expect codex (plus a new one pinning the explicit-prefix override); the rest were already correct and pass again untouched. Adds a regression test for the OpenAI-only case. * docs(changelog): correct fragment id to cheaper-inference#9447 * test(routing): seed an active codex connection in the bare-precedence guards The two files cheaper-inference#9275 added assert that bare gpt-5.5 / gpt-5.6-sol reach codex, but they ran against an empty database — so they also pinned 'codex wins with no codex connection at all', which is the regression cheaper-inference#9447 removes. That put them in direct contradiction with plan3-p0 / chat-helpers / codex-gpt55-routing-5887, which assert openai for the very same input: no implementation could satisfy both, which is why the release could not go green. Seeding an active codex connection keeps the contract these files were written to guard (codex beats openai for a Codex-native bare id) while dropping the accidental 'even with no codex configured' half. Cases that need no connection are left as they were: the tier-only ids and codex-auto-review have no alternative provider to preempt, and the explicit-prefix overrides are unaffected. --------- Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…nce#10213) * fix(ci): clear base-reds on release/v3.8.50 (round 3) - CHANGELOG.md: restore the top [Unreleased] section dropped by the cheaper-inference#10189 reconcile (docs-sync gate: first section must be Unreleased) - env-doc-sync: document CONDUCTOR_ORCHESTRATOR_TOKEN + CONDUCTOR_SPOKESPERSON_URL in .env.example/ENVIRONMENT.md; allowlist the CI-only GITHUB_STEP_SUMMARY and TS7_BASE_REF (ts7 ratchet signals); drop a stray merge artifact line - providers: restore the audited chatanywhere metadata entry that base-reds round 2 dropped together with its duplicate — the provider was half-wired (registry+endpoint without APIKEY metadata), which is what the wave3 test catches; re-pin providers-constants-split at the measured 228 - docs counts: 338 -> 339 (today's +2 void-ai/helixmind, -1 Puter) via gen:provider-reference + README/AGENTS/llm.txt/package.json/diagrams/i18n mirrors - file-size ratchet: annotated rebaseline for the two pre-existing drifts (ModelSelectModal 1138, gateways 1250) following the 2026-08-11 precedent Refs cheaper-inference#9985 * fix(ci): base-reds round 3b — stale sibling tests + mode-pack weight contract - check-docs-counts-sync.test.ts: drop the imports/subtests of the four helpers cheaper-inference#10196 removed from the gate script (readMcpFactsFromSource, listLocalizedDocs, makeRequiredCountsValidator, checkFreeTierInventory) — the new-API tests that cheaper-inference#10196 added stay; the file now loads again under the node runner - quota-connection-recovery.test.ts: convert from vitest APIs to node:test — the file lives in tests/unit/*.test.ts (node-runner glob) and the vitest runtime crashes when imported outside vitest, killing the whole shard entry - modePacks.ts: re-normalize all six mode packs to sum 1.0 — cheaper-inference#8940 added sessionAvailability: 0.05 to every pack without rebalancing (1.05 total); ratios preserved exactly (÷1.05), so post-normalizeScoringWeights behavior is unchanged; restores the declared sum-to-1.0 contract the 4235 test pins Refs cheaper-inference#9985 * fix(ci): base-reds round 3c — vitest siblings, weights default, secrets FP, mutation tap - DistributeProxiesButton.test.tsx: wrap renders in NextIntlClientProvider — cheaper-inference#9245 localized the component (useTranslations) and left the test without the intl context, failing all 14 cases - scoring.ts: re-normalize DEFAULT_WEIGHTS to sum 1.0 (same cheaper-inference#8940 class as the mode packs — sessionAvailability added without rebalancing; ratios preserved) - .gitleaks.toml: generalize the kimi sponsor-banner localStorage-key allowlist to -v\d+ — cheaper-inference#10200 bumped v1→v2 and the stale regex regressed the secrets ratchet with a false positive - stryker.conf.json: register 6 covering unit tests in tap.testFiles (4 modules) so their mutant kills count — unblocks check:mutation-test-coverage --strict Refs cheaper-inference#9985 * fix(ci): base-reds round 3d — inspector factor gap, stale registry/gap tests, i18n key sync - comboScoringInspector: add cacheAffinity/sessionAvailability/connectionDensity to FACTOR_KEYS + the factor-key type — calculateScore() weighs them but the breakdown omitted them, so the explained contributions never summed to the reported score (inspector bug, red on the pure tip) - combo-scoring-inspector.test: make the explicit-weights override sum-neutral (±0.05 shift) so it stays valid for any DEFAULT_WEIGHTS values — the hardcoded override only summed to 1.0 against the pre-cheaper-inference#8940 defaults, which is also why explicit weights silently fell back to 'default' on the tip - unorouter-registry.test: align to the canonical .com host (api.unorouter.ai 301-redirects there, verified live) and to wave4's live model discovery (passthrough, no static seed) — the .ai/auto-model expectations were stale - check-migration-numbering.test: 147 left KNOWN_GAPS when 147_api_keys_model_access_mode.sql landed — assert absent (same as 143) - i18n: sync-ui pass — 35,914 missing UI keys stamped as __MISSING__ placeholders across 42 locales (mechanical; greens the pt-BR key-presence integrity test; coverage pct unchanged by design — translation is a separate workstream) Refs cheaper-inference#9985 * fix(ci): base-reds round 3e — 2 real defects + 14 stale sibling tests (waves A-E) Real defects fixed: - src/lib/db/apiKeys.ts: cheaper-inference#9313's empty-allowlist early return bypassed the group permission check, silently disabling group deny rules (cheaper-inference#8817) for every key without a per-key allowlist; fall-through restored, restricted+[] deny-all kept - open-sse/utils/proxyFetch.ts: cheaper-inference#10032 re-appended the raw transport error to the propagated message, reintroducing the proxy user:password leak cheaper-inference#9837 closed; new redactProxyDetailsInMessage() keeps the reason, redacts URL/credentials - .github/workflows/quality.yml: cheaper-inference#10134 added the TS7 ratchet as a separate blocking step AFTER the aggregated gates — the exact cheaper-inference#8542 masking mechanism; folded into the non-fail-fast loop (still blocking, still PR-only)⚠️ CI edit, gate-strengthening — explicit owner sign-off requested on the PR - src/i18n/messages/ko.json: 3 machine-mistranslation regressions caught by the cheaper-inference#8244 glossary checker (장애인→비활성화됨, 양말5://→socks5://, 비클로드→Claude가 아닌) Stale sibling tests aligned to deliberately-moved contracts (each cites its mover): request-log-detail-layout + -stream (cheaper-inference#9245 intl provider), repro-8542 pin update, quality-rail-gate-membership (cheaper-inference#10134 shape), agentSkills-routes 45→46 (cheaper-inference#9058), cloudflare-ai-catalog-8717 (cheaper-inference#8804 supersedes cheaper-inference#8808), executor-xai (cheaper-inference#9994), vision-bridge-claude-wire (cheaper-inference#9463 minimax→openai), sse-auth forced-pin (cheaper-inference#8893), tls-proxy-context (strengthened leak guards), rate-limit-local-error-classification (cheaper-inference#9164/cheaper-inference#9342), minimax-thinking-signature (cheaper-inference#9463), codebuddy-cn (cheaper-inference#9723 +1 test), github-copilot-custom-model (cheaper-inference#9050), providers-g4f-batch3 (cheaper-inference#9584), synced-capability-warmup (cheaper-inference#9199, stricter), sidebar-tools-group (cheaper-inference#8221), oauth-modal-grok-cli-paste (cheaper-inference#9245); agentSkills/catalog.ts comment 45→46; file-size rebaseline for proxyFetch (+19, annotated) Refs cheaper-inference#9985 * fix(ci): base-reds round 3f — waves F-J: 9 more real defects + stale sibling sweep Real production defects fixed (all red on the pure tip, each with its origin): - routeGuard.ts: cheaper-inference#8949 accidentally DELETED the /api/providers/[id]/login local-only pattern — the route spawns a browser, so the loopback gate for a process-spawning route was gone (Hard Rules cheaper-inference#15/cheaper-inference#17); restored (314 guard tests green) - agentSkills generator: cheaper-inference#9058's category dispatch gave the config category an empty body, wiping skills/config-codex-cli/SKILL.md at the cheaper-inference#10131 sync; fixed + SKILL.md regenerated via the official generator - imageRegistry: cheaper-inference#9982 broke same-provider bare aliasing (antigravity preview id sent upstream unresolved); new resolveSameProviderBareAlias() keeps the fal cross-provider fix intact - imageRegistry: cheaper-inference#9982's prefix strip handed the bare nano-banana ids to fal-ai, violating the pinned 2026-07-31 operator decision (adobe-firefly owns them); fal entries made prefix-only (dispatch already re-prefixes) - mediaGeneration/fal.ts: the missing-credential 401 guard was lost when cheaper-inference#10198 deleted the superseded falHandler — tests were hitting the live network - bottleneckPatch/rateLimitManager: cheaper-inference#9041's merge clobbered cheaper-inference#9604, resurrecting the Bottleneck v2.19.5 heartbeat bug (reservoir never refills); patched the library defect at the root and re-aligned chat-rate-limit-body-lock to the working reservoir contract - processSupervisor.mjs: cheaper-inference#9761 regressed the Node spawn to bare "node" (the cheaper-inference#9156 launchd bug) and dropped cheaper-inference#9209's ipv4first args; both restored - openai-responses/pureHelpers: cheaper-inference#9423's Agent null-sentinel was unreachable on the schemaless JSON-string path; gate extended - i18n en.json: cheaper-inference#8222's regen reverted the cheaper-inference#9976 unclosed-tag fix and cheaper-inference#8559's combo-cooldown copy; cheaper-inference#9038 shipped 40 t() calls with no messages (runtime MISSING_MESSAGE); all restored/added + official sync-ui stamps, and vi's zero-marker policy re-established via the sanctioned translation backend Stale sibling tests aligned (movers cited inline): chat-helpers (cheaper-inference#9447), executor-antigravity (cheaper-inference#9351), video-fal-grok (cheaper-inference#9982), visionBridge (cheaper-inference#9759), web-session-credentials (cheaper-inference#8974), production-build-module-integrity (positive anchor added), agentSkills-generator/skillManifestsLint/skills-injection/ agentSkillTools-mcp/listCapabilities-a2a (cheaper-inference#9058), memory-settings (cheaper-inference#10010), model-catalog-policy-invalidation (cheaper-inference#8906), model-alias-seed (cheaper-inference#9485), reactive-context-compaction (cheaper-inference#8949), combo-provider-wildcard (broken upsert helper), oauth-google-loopback (43-locale resurrected-key removal) Validation: 501/501 across the 47 touched test files; typecheck:core, lint, file-size, docs-sync all green. Refs cheaper-inference#9985 * fix(ci): base-reds round 3g — wave K/L: 4 more real defects + stale alignments Real defects: - base/reasoningEffort.ts: the stale duplicate cherry-pick cheaper-inference#9612 re-added the codex minimal→low rewrite that cheaper-inference#9883 had deliberately removed (OMP minimal passthrough); block removed again - cursorImages.ts: cheaper-inference#9840 wired prepareCursorImageForWire (sharp re-encode, fail-closed) into the SHARED resolveCursorImages, breaking zai-web and conol-web image uploads (HTTP 400 'undecodable'); new prepareForWire opt-out, Cursor default path unchanged (8 cursor suites green) - modelCapabilities/snapshot: catalog prepare still issued 323 per-model reads of model_context_overrides + max_input_tokens overrides, violating cheaper-inference#9199's bulk-load contract; both now resolve from the snapshot single pass - v1-models-discovery-conformance: re-pinned to the bounded 30s SWR window (cheaper-inference#9199/cheaper-inference#10198) — the old 'stale-first regardless of age' contract is gone Stale tests aligned (movers cited inline): codex-tools-strict-default (cheaper-inference#9828 redundant-oneOf strip), devin-providers (cheaper-inference#9245 i18n), db-migrationrunner- constants-split (147→151 renumber cheaper-inference#8228), gitlab-duo-oauth-setup (cheaper-inference#9245), chatcore-extracted-modules (cheaper-inference#9161 outbound-protocol keying) compression-api CI failures were cascade artifacts of codex-tools-strict-default failing in the same force-exit shard process — no own defect (171/171 local). Refs cheaper-inference#9985 * fix(test): compression-api — register both describes before the runner starts The DATA_DIR setup + route/db top-level awaits sat BETWEEN the two describes; under --test-force-exit (the CI unit-runner flag) the process exits once the already-registered tests finish, so on slow CI machines the whole second describe died as 'Promise resolution is still pending' — the recurring CI-only shard-2 failure that never reproduced locally without the flag. Moved to the top of the file; 10/10 under --test-force-exit locally. Refs cheaper-inference#9985 * fix(quality): freeze modelCapabilities.ts at 1006 (annotated) — snapshot routing growth Refs cheaper-inference#9985 * fix(quality): move the modelCapabilities freeze into the frozen map (nested schema) Refs cheaper-inference#9985 * fix(i18n): translate all 39,718 pending UI keys across 42 locales (owner-approved) Mass-translated every __MISSING__ placeholder via the official i18n:sync-ui --translate-markers pipeline (operator backend), restoring i18nUiCoverage to the 100 baseline (was 89.9 after the merge-storm UI landings + the 42 keys cheaper-inference#9038 never shipped). Post-pass repairs, all caught by the existing gates: - glossary: retired renderings the machine reintroduced normalized again (提供商→提供者 zh-CN/zh-TW, 鏈接→連結, 文檔→文件, 調用→呼叫, 供應商→提供者, 響應→回應, 不活躍→未啟用 zh-TW; 클로드→Claude, 옴니루트→OmniRoute ko); DATA_DIR forbidden rendering avoided via 数据文件夹 rephrase - ICU integrity: 120 values with renamed/dropped {params} repaired (39 positional renames, 81 reset to the en source — functional over fluent) Validation: glossary/pt-BR/vi/deno-relay/settings-keys/value-drift/google- loopback suites 76/76; placeholder diff en×42 locales = 0; worst-locale coverage = 100.0%. Refs cheaper-inference#9985 --------- Co-authored-by: backryun <bakryun0718@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release is red, and this is why
release/v3.8.50has been failing 15 unit tests since #9275 merged on 2026-08-03. Every PR opened against it inherits those failures — #9425, which changes one YAML file and one markdown file, currently failsFast Quality Gatesand all fourUnit Testsshards. In a queue sweep today, 67 open PRs were red on nothing but this shared base-red.Root cause
#9275 widened
CODEX_NATIVE_UNPREFIXED_MODELSfrom a single id togpt-5.5plus thegpt-5.6-sol/terra/lunatiers — a deliberate fix, so bare Codex CLI ids reach the ChatGPT subscription instead of fanning out. But the early return it added toresolveModelByProviderInferencenever consults the active-provider set:That made the guard 30 lines below unreachable for all 27 ids in the set — the one whose own comment reads "Route overlapping models through Codex only for Codex-only installations; when OpenAI is also active, preserve the historical OpenAI default below."
User-visible effect: an OpenAI-only install asking for bare
gpt-5.5is routed tocodex— a provider it has no connection for — and fails withno active credentials for provider: codexon a model OpenAI serves fine. An install whose codex connection is merely inactive fails identically. It also silently reverted #5887's compatibility boundary.The fix
The Codex preference may only preempt another provider when a codex connection is actually active:
codex-auto-review) → still resolve to codex with no connection at all. There is no alternative to preempt, andno codex credentialsis the honest error.openai/…prefix → still authoritative, in every case.Tests
Of the 13 failing routing assertions, 10 were correct all along and pass again with no edit — they were reporting the regression, not lagging behind it. Only 3 encoded the intended #9275 change and were updated to expect
codex, each with a comment explaining the moved boundary.Added:
#5887(b2)— an explicitopenai/prefix overrides the Codex-native set.a Codex-native bare id stays on OpenAI when no codex connection exists— the permanent guard for this regression.Validation
Before the fix these same files were 13 fail / 77 pass.
typecheck:core, scoped eslint,check-complexity,check-cognitive-complexityandcheck-changelog-integrityall pass.Not covered here: the remaining 2 failures in
vscode-token-routes.test.ts(a trailing period in the no-credentials message) belong to #9392 by @HouMinXi, which should land alongside this. Together they take the release back to green.Also still open, and untouched by this PR:
check-file-sizereportssrc/sse/handlers/chat.ts1846>1845 andopen-sse/executors/base.ts1623>1578 on the bare tip — baseline drift for the release captain.