Repository navigation
chore(ci): stop dependabot from grouping ioredis majors with routine bumps - #9425
Conversation
…bumps ioredis is loaded through a dynamic import in the distributed quota store, so a breaking major passes build, typecheck and both test suites and only surfaces at runtime for operators running Redis-backed quota. #9310 grouped ioredis 5.10.1 to 6.0.0 with 9 unrelated production bumps; majors get their own PR from now on.
|
Merged via local merge-train on 192.168.0.113 (32 cores) @ train tip Green: This was the first train of the day to run against a genuinely clean base — #9447 and #9392 had just taken the release back to green after 15 unit failures inherited from #9275 — so every red here was re-run in isolation on the exact train tip rather than assumed. All of them passed:
No failure was attributable to any boarded PR. For reference, |
…bumps (cheaper-inference#9425) * chore(ci): stop dependabot from grouping ioredis majors with routine bumps ioredis is loaded through a dynamic import in the distributed quota store, so a breaking major passes build, typecheck and both test suites and only surfaces at runtime for operators running Redis-backed quota. cheaper-inference#9310 grouped ioredis 5.10.1 to 6.0.0 with 9 unrelated production bumps; majors get their own PR from now on. * docs(changelog): add fragment for cheaper-inference#9425 --------- Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com>
Why
#9310("deps: bump the production group with 10 updates") carriesioredis5.10.1 → 6.0.0 — a breaking major — alongside 9 routine bumps (axios, jose, playwright, better-sqlite3, fumadocs, lucide-react, material-symbols, aws-sdk).That combination is unusually hard to catch:
ioredisis a soft/optional dependency resolved through a dynamic import insrc/lib/quota/redisQuotaStore.ts(Redis driver requires ioredis package), so a breaking API change cannot fail the build ortypecheck:core.src/lib/quota/storeFactory.tsand animport type Redisinsrc/shared/utils/rateLimiter.ts— types, not runtime.test:unitortest:vitestopens a live Redis connection.So a v5→v6 break ships fully green and surfaces only at runtime, for operators running Redis-backed distributed quota — the users least able to absorb a surprise.
What changes
Adds
ioredisto the existingignorelist for majors only (minors and patches keep flowing), following the same convention already used fortypescript,jscpd,nextand@huggingface/transformers, each with its justification inline.Minor/patch bumps are unaffected. The ioredis 6 migration gets its own PR and its own review when we choose to do it.
Validation
Config-only change to
.github/dependabot.yml; no product code touched.