Skip to content

fix(types): declare virtual chaos combo config - #8815

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
backryun:chore/ts7-types-auto-chaos-config
Jul 28, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.49from
backryun:chore/ts7-types-auto-chaos-config

Conversation

@backryun

Copy link
Copy Markdown
Contributor

Part of #8484. One incomplete producer contract, three diagnostics, zero new.

Root cause

createVirtualAutoCombo("chaos") already emits config.chaos with the enablement flag,
panel metadata, judge model, and tuning values. Its VirtualAutoCombo return type described only
config.auto, so the real factory integration test could not access the chaos configuration
without TS2339 errors.

This adds the existing optional chaos shape to the producer contract and reuses the shared
ChaosTuning type. Runtime values and routing behavior are unchanged; the test remains untouched.

Diagnostics

Measured independently against release/v3.8.49 at 0eeb8f45c:

  • TypeScript 6 open-sse diagnostics: 150 → 147
  • TypeScript 7.0.2 native diagnostics: 149 → 146
  • Full line-number-agnostic error-set diff: 3 fixed, 0 new

With #8809, #8810, #8811, and #8812 included, the cumulative projection is
TS6 134 / TS7 133.

Validation

  • npm run typecheck:core
  • Auto-combo factory, chaos dispatch, and scoring tests — 70/70 passed
  • ESLint on open-sse/services/autoCombo/virtualFactory.ts
  • npm run check:file-size
  • Prettier and git diff --check

No new test was added because the existing chaosVirtualCombo integration test directly verifies
every field added to the return contract.

Known inherited CI failures

The current base is red on an unrelated React hook dependency and a stale
pack-artifact-policy.test.ts expected list. Both failures were reproduced identically on
release/v3.8.49@0eeb8f45c and #8809's head; this diff touches neither area.

@backryun
backryun marked this pull request as ready for review July 27, 2026 23:29
@backryun
backryun requested a review from diegosouzapw as a code owner July 27, 2026 23:29
@diegosouzapw
diegosouzapw merged commit 0bd7cea into cheaper-inference:release/v3.8.49 Jul 28, 2026
13 checks passed
@backryun
backryun deleted the chore/ts7-types-auto-chaos-config branch July 28, 2026 02:14
@diegosouzapw diegosouzapw mentioned this pull request Jul 28, 2026
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants