Repository navigation
fix(types): preserve compression detail config shapes - #8812
Merged
diegosouzapw merged 1 commit intoJul 28, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
backryun
marked this pull request as ready for review
July 27, 2026 23:16
diegosouzapw
merged commit Jul 28, 2026
5f5f4a5
into
cheaper-inference:release/v3.8.49
13 checks passed
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8484. Three unnecessary type erasures, three diagnostics, zero new.
Root cause
resolveStepDetailConfig()forcedHeadroomConfig,SessionDedupConfig, andCcrConfigthrough
Record<string, unknown>assertions even though its only consumer immediately spreads thereturned detail object into
stepConfig. These interfaces intentionally have specific fields andno string index signature, so the assertions triggered TS2352.
This removes the explicit
Recordreturn annotation and the three assertions, allowing theexisting detail-config union to flow into the spread operation. Returned values and pipeline
behavior are unchanged.
Diagnostics
Measured independently against
release/v3.8.49at0eeb8f45c:With #8809, #8810, and #8811 included, the cumulative projection is
TS6 137 / TS7 136.
Validation
npm run typecheck:core14/14 passed
open-sse/services/compression/stepDetailConfig.tsnpm run check:file-sizegit diff --checkNo new runtime test was added because the returned objects and merge order are unchanged, while
the existing focused tests cover all three persisted detail sections and the stacked-pipeline
consumer.