Skip to content

refactor: extract textual tool calls to open-sse/utils/stream/textualToolCalls.ts (Issue #3594) - #3920

Closed
oyi77 wants to merge 3 commits into
cheaper-inference:release/v3.8.28from
oyi77:pr/stream-textual
Closed

oyi77 wants to merge 3 commits into
cheaper-inference:release/v3.8.28from
oyi77:pr/stream-textual

Conversation

@oyi77

@oyi77 oyi77 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Part of modularization effort (Issue #3594).

Extracts textual tool call parsing from the monolithic open-sse/utils/stream.ts into a dedicated module.

Changes:

  • New file: open-sse/utils/stream/textualToolCalls.ts (84 lines)
  • Exports: parseTextualToolCallFromContent, containsTextualToolCallCandidate, containsMalformedTextualToolCall, extractAllowedToolNames, collectPassthroughTextualToolCall

Testing: No behavior change. Existing stream tests pass.

Follow-up PRs will extract: types (#3917), utils (#3918), errors (#3919), sseFormatters, openaiChunks, claudeLifecycle, responsesLifecycle, and streamCore.

@oyi77
oyi77 requested a review from diegosouzapw as a code owner June 15, 2026 20:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility file open-sse/utils/stream/textualToolCalls.ts to handle parsing, validation, and collection of textual tool calls from content streams. A critical issue was identified where the code references parseTextualToolCallCandidate and isValidToolCallHeaderPrefix without importing them, which will result in runtime ReferenceErrors. Additionally, there are unused imports for convertOpenAIToResponsesToolCall and uuidv4 that should be cleaned up.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +1 to +5
import { convertOpenAIToResponsesToolCall } from "../handlers/responseTranslator.ts";
import { v4 as uuidv4 } from "uuid";

import { asRecord } from "./utils.ts";
import { JsonRecord, ToolCall } from "./types.ts";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly created file references parseTextualToolCallCandidate and isValidToolCallHeaderPrefix but does not import them, which will lead to runtime ReferenceErrors. Additionally, convertOpenAIToResponsesToolCall and uuidv4 are imported but never used. Let's clean up the unused imports and add the missing ones.

Suggested change
import { convertOpenAIToResponsesToolCall } from "../handlers/responseTranslator.ts";
import { v4 as uuidv4 } from "uuid";
import { asRecord } from "./utils.ts";
import { JsonRecord, ToolCall } from "./types.ts";
import { asRecord } from "./utils.ts";
import { JsonRecord, ToolCall } from "./types.ts";
import { parseTextualToolCallCandidate, isValidToolCallHeaderPrefix } from "../textualToolCall.ts";

@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.26 to release/v3.8.27 June 16, 2026 06:19
oyi77 added 2 commits June 16, 2026 16:12
…ToolCalls.ts

Part of Issue cheaper-inference#3594 modularization. Extracted textual tool call parsing from the monolithic stream.ts.

Exports:
- parseTextualToolCallFromContent, containsTextualToolCallCandidate
- containsMalformedTextualToolCall, extractAllowedToolNames
- collectPassthroughTextualToolCall
@oyi77
oyi77 force-pushed the pr/stream-textual branch from d5f25f4 to 3246b01 Compare June 16, 2026 09:12
@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.27 to release/v3.8.28 June 17, 2026 08:20
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks, @oyi77 🙏. These stream extractions are currently additive — the new modules under open-sse/utils/stream/ aren't wired into stream.ts yet, so they don't change runtime behavior on their own. Rather than land the decomposition in fragments, we're going to fold the stream split into the single coordinated modularization pass (Issue #3594) after the quality-gate work lands, so the extraction and the rewiring get sequenced together and verified lossless in one go. Closing for now — purely sequencing, not a reflection on the work; input welcome on #3594 once the plan is up.

@oyi77
oyi77 deleted the pr/stream-textual branch August 7, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants