Skip to content

refactor: extract stream types to open-sse/utils/stream/types.ts (Issue #3594) - #3917

Closed
oyi77 wants to merge 3 commits into
cheaper-inference:release/v3.8.28from
oyi77:pr/stream-types
Closed

oyi77 wants to merge 3 commits into
cheaper-inference:release/v3.8.28from
oyi77:pr/stream-types

Conversation

@oyi77

@oyi77 oyi77 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Part of modularization effort (Issue #3594).

Extracts type definitions from the monolithic open-sse/utils/stream.ts into a dedicated module.

Changes:

  • New file: open-sse/utils/stream/types.ts (138 lines)
  • Exports: StreamOptions, StreamLogger, StreamCompletePayload, StreamFailurePayload, TranslateState, ToolCall, UsageTokenRecord, SSEStreamContext, JsonRecord

Testing: No behavior change - types only. Existing stream tests pass.

Follow-up PRs will extract: utils, errors, textualToolCalls, sseFormatters, openaiChunks, claudeLifecycle, responsesLifecycle, and streamCore.

@oyi77
oyi77 requested a review from diegosouzapw as a code owner June 15, 2026 20:13

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new types file open-sse/utils/stream/types.ts containing various type definitions for SSE streaming, including SSEStreamContext and StreamOptions. Feedback was provided regarding unused imports and a missing import for initState which would cause TypeScript compilation errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread open-sse/utils/stream/types.ts Outdated
Comment on lines +1 to +2
import { convertOpenAIToResponsesToolCall } from "../handlers/responseTranslator.ts";
import { v4 as uuidv4 } from "uuid";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The imports on lines 1 and 2 are unused in this file. Additionally, convertOpenAIToResponsesToolCall is not exported by ../handlers/responseTranslator.ts, and TranslateState (line 45) references initState which is not imported or defined in this file. This will cause TypeScript compilation errors.\n\nRemove the unused imports and import initState from ../stream.ts instead.

Suggested change
import { convertOpenAIToResponsesToolCall } from "../handlers/responseTranslator.ts";
import { v4 as uuidv4 } from "uuid";
import { initState } from "../stream.ts";

@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.26 to release/v3.8.27 June 16, 2026 06:19
oyi77 added 2 commits June 16, 2026 16:12
Part of Issue cheaper-inference#3594 modularization. Extracted type definitions from the monolithic stream.ts into a dedicated module.

Types exported:
- StreamOptions, StreamLogger, StreamCompletePayload, StreamFailurePayload
- TranslateState, ToolCall, UsageTokenRecord
- SSEStreamContext, JsonRecord
Fixes TypeScript error: TranslateState references initState without import.
@oyi77
oyi77 force-pushed the pr/stream-types branch from 0d4704d to 102c9c2 Compare June 16, 2026 09:12
@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.27 to release/v3.8.28 June 17, 2026 08:20
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks, @oyi77 🙏. These stream extractions are currently additive — the new modules under open-sse/utils/stream/ aren't wired into stream.ts yet, so they don't change runtime behavior on their own. Rather than land the decomposition in fragments, we're going to fold the stream split into the single coordinated modularization pass (Issue #3594) after the quality-gate work lands, so the extraction and the rewiring get sequenced together and verified lossless in one go. Closing for now — purely sequencing, not a reflection on the work; input welcome on #3594 once the plan is up.

@oyi77
oyi77 deleted the pr/stream-types branch August 7, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants