Repository navigation
fix(provider-models): keep a deleted synced model deleted across re-fetch (#3199) - #3212
Merged
Merged
Conversation
…etch (#3199) Follow-up to #3204: deleting a synced (fetched) model removed it from the synced set, but the DELETE route didn't mark it hidden and the re-import path didn't skip hidden ids, so the next auto-fetch re-added it. Now the route marks the id hidden on delete and replaceSyncedAvailableModelsForConnection filters hidden ids, so the deletion sticks. Co-authored-by: tjengbudi <tjengbudi@users.noreply.github.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 5, 2026
Closed
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…etch (cheaper-inference#3199) (cheaper-inference#3212) Follow-up to cheaper-inference#3204: deleting a synced (fetched) model removed it from the synced set, but the DELETE route didn't mark it hidden and the re-import path didn't skip hidden ids, so the next auto-fetch re-added it. Now the route marks the id hidden on delete and replaceSyncedAvailableModelsForConnection filters hidden ids, so the deletion sticks. Co-authored-by: tjengbudi <tjengbudi@users.noreply.github.com>
Poid-ZA
pushed a commit
to Poid-ZA/OmniRoute
that referenced
this pull request
Aug 5, 2026
…etch (cheaper-inference#3199) (cheaper-inference#3212) Follow-up to cheaper-inference#3204: deleting a synced (fetched) model removed it from the synced set, but the DELETE route didn't mark it hidden and the re-import path didn't skip hidden ids, so the next auto-fetch re-added it. Now the route marks the id hidden on delete and replaceSyncedAvailableModelsForConnection filters hidden ids, so the deletion sticks. Co-authored-by: tjengbudi <tjengbudi@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…etch (cheaper-inference#3199) (cheaper-inference#3212) Follow-up to cheaper-inference#3204: deleting a synced (fetched) model removed it from the synced set, but the DELETE route didn't mark it hidden and the re-import path didn't skip hidden ids, so the next auto-fetch re-added it. Now the route marks the id hidden on delete and replaceSyncedAvailableModelsForConnection filters hidden ids, so the deletion sticks. Co-authored-by: tjengbudi <tjengbudi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3199 (follow-up to #3204).
#3204 added the synced-model delete, but a deleted model reappeared on the next auto-fetch: the DELETE route didn't mark it hidden and
replaceSyncedAvailableModelsForConnectiondidn't skip hidden ids. Now the route marks the id hidden on delete and the re-import filters hidden ids, so the deletion persists (which is what the reporter needs — otherwise the model 'can't be deleted').Regression test:
tests/unit/synced-model-delete-persist-3199.test.ts(fails on the pre-fix re-import path). Thanks @tjengbudi.