[wilsonicdev]

Fixes #3199.

Problem

Models fetched from providers like llamacpp are stored in the
'syncedAvailableModels' namespace (key = providerId:connectionId).
The DELETE /api/provider-models handler only called removeCustomModel(),
which operates on the 'customModels' namespace. Since fetched models are
never in customModels, removeCustomModel() returned false and the model
remained visible after deletion.

Fix

1. Added removeSyncedAvailableModel() in src/lib/db/models.ts that scans
   all connection-scoped synced model lists for a provider, removes the
   target model, and deletes the key if the list becomes empty.
2. Exported it through src/lib/localDb.ts.
3. Updated DELETE handler in src/app/api/provider-models/route.ts to
   call both removeCustomModel() and removeSyncedAvailableModel(),
   returning true if either succeeds.

Tests

Added tests/unit/llamacpp-model-delete.test.ts with 3 assertions:

• removeSyncedAvailableModel deletes a model from multiple connections
• removeSyncedAvailableModel deletes the key when a connection becomes empty
• removeSyncedAvailableModel returns false when model does not exist

All 3 pass.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[kilo-code-bot]

Code Review Summary

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	1
SUGGESTION	1

Issue Details (click to expand)

CRITICAL

File	Line	Issue
src/lib/db/models.ts	748	Missing transaction for multi-write operation

WARNING

File	Line	Issue
src/lib/db/models.ts	752	Unhandled JSON.parse error

SUGGESTION

File	Line	Issue
src/lib/db/models.ts	767	Backup should be inside transaction

Files Reviewed (3 files)

• src/lib/db/models.ts - 3 issues
• src/app/api/provider-models/route.ts - No issues
• tests/unit/llamacpp-model-delete.test.ts - No issues (good test coverage)

---

_{Reviewed by step-3.7-flash-20260528 · 870,002 tokens}

[diegosouzapw]

Merged into release/v3.8.11 — thanks @wilsonicdev! 🙏

Good catch on #3199: fetched/synced models live in the syncedAvailableModels namespace, but DELETE /api/provider-models only called removeCustomModel() (which operates on customModels), so deleting a llamacpp model silently no-op'd. Adding removeSyncedAvailableModel() and wiring it into the delete handler fixes it. localDb.ts stays a pure re-export (the logic lives in db/models.ts) — nicely within conventions.

Verified before merge: 4/4 llamacpp-model-delete tests green, lint clean, Semgrep passed. (Rebased onto the release branch; the only conflicts were unrelated fork-drift in package.json/antigravity.ts/openapi.yaml, resolved to the release versions — your fix is untouched.) Ships in the next release.