Skip to content

fix(sse): restore the missing getComboByName import - #18523

Open
RaviTharuma wants to merge 2 commits into
cheaper-inference:release/v3.8.53from
RaviTharuma:fix-model-combo-byname-import
Open

RaviTharuma wants to merge 2 commits into
cheaper-inference:release/v3.8.53from
RaviTharuma:fix-model-combo-byname-import

Conversation

@RaviTharuma

Copy link
Copy Markdown
Contributor

Summary

  • Restore the missing `getComboByName` import in `src/sse/services/model.ts`.
  • Client-namespaced combo resolution (`/`) was throwing `ReferenceError: getComboByName is not defined` at runtime for every request on that path.
  • This also restores the required API Route Typecheck gate (`TS2304`) without widening its frozen baseline.

Related Issues

  • Related to the active-release API Route Typecheck regression and a runtime ReferenceError on client-namespaced combo resolution introduced with the `getComboByName` call site.

Target Branch

See the Release Strategy, the
Contribution Golden Path and the
ROADMAP:

  • Base is the active `release/v3.8.x` branch (the highest open `release/v*`), not `main`
  • New feature? From 3.8.55 on it is held with the `v4-feature` label for the v4 channel
  • Focused templates: append `?template=feature.md` or `?template=bugfix.md` to the compare URL

Validation

  • Change type: routing
  • Focused tests and category gates from the golden path
  • `node scripts/check/check-api-typecheck.mjs`
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes are covered by existing automated tests

Tests Added Or Updated

  • No new test file. `tests/unit/combo-prefixed-name-resolve.test.ts` already covers this exact code path and was failing at runtime with `ReferenceError: getComboByName is not defined` before this fix (5 of 13 tests); all 13 pass after the fix.

Coverage Notes

  • Single-line import fix in `src/sse/services/model.ts`. Fully covered by the existing `tests/unit/combo-prefixed-name-resolve.test.ts` suite, which exercises the exact broken call site.

Reviewer Notes

  • Surgical release-base unblocker found while diagnosing an unrelated PR's CI failures. Verified on a fresh, untouched clone of `release/v3.8.53` that this ReferenceError and the TS2304 typecheck error both reproduce before the fix and are gone after.
  • No migrations, feature flags, or behavior changes beyond restoring the intended bare-name combo lookup.

Client-namespaced combo resolution (<namespace>/<combo>) was throwing
ReferenceError: getComboByName is not defined at runtime, failing every
request on that path and the five existing unit tests covering it.
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T00:49:32.023190Z
We couldn’t complete this review. Comment @codex review to try again.
6d941d8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Dependency note for #18368

#18368 ("fix(combo): fall back from protected priority on structured context overflow") never touches src/sse/services/model.ts, so it cannot carry this fix itself. But #18368's own API Route Typecheck check is red solely because that gate runs tsc over the whole src/app/api/** scope, and this file's missing import (getComboByName) is inside that scope.

Intended merge order:

  1. Merge this PR (fix(sse): restore the missing getComboByName import #18523) first.
  2. Rebase/update fix(combo): fall back from protected priority on structured context overflow #18368 onto the post-merge release/v3.8.53 tip.
  3. fix(combo): fall back from protected priority on structured context overflow #18368's API Route Typecheck should then go green.

Note: #18368's separate Lint failure (check:dashboard-typecheck, ~12 unrelated dashboard errors e.g. packages/ui-kit/src/tooltip.tsx, src/app/(dashboard)/dashboard/logs/page.tsx) is a different, still-open release-wide issue that this PR does not fix. It will likely remain red on #18368 even after this PR merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred-v3.8.54 Feat PRs held for v3.8.54. Keep open. Do not merge into v3.8.53.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants