Skip to content

fix(ci): restore Claude translator types and mutation test registration - #16806

Closed
diegosouzapw wants to merge 3 commits into
release/v3.8.52from
fix/base-types-five-1016
Closed

diegosouzapw wants to merge 3 commits into
release/v3.8.52from
fix/base-types-five-1016

Conversation

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Summary

The release core typecheck reports 57 diagnostics in Claude request/response translation and the DSML parser. Explicit collection and credential types preserve the existing payload contracts; normal control-flow narrowing handles optional thinking and tools, and translator registration uses its existing optional arguments. DSML closing-tag parsing uses RegExp.exec, whose match index is required, with coverage for multiple calls, zero-offset closers and incomplete calls.

The strict mutation registration gate also reports 15 missing module/test relations. Register the 11 existing covering test files so their assertions participate in nightly mutation runs; no thresholds, mutate targets or typecheck baselines change.

Refs #15306. This addresses these specific base failures; it does not close the release-wide tracker.

Tests Added Or Updated

  • tests/unit/dsml-tool-calls.test.ts: successive calls with surrounding prose, empty call with closer at offset zero, mismatched closer held as an incomplete call.

Validation

Frozen base 8f4b3da. Exact Node 24.21.0 and lockfile dependency versions audited on the isolated validation host (2524 installed packages, no mismatches or missing required packages).

  • Core typecheck: RED 57 errors before changes → GREEN exit 0.
  • open-sse raw typecheck already passes on this base after earlier merged PRs; final workspace ratchet also passes (exit 0).
  • DSML characterization 9/9 before and 9/9 after.
  • Mutation registry RED 15 relations → GREEN zero drift; 110/110 assertions from 11 registered test files plus the gate unit tests pass.
  • 59 related Claude/DSML regression files: 411/412 pass. The sole failure (repro-10139-claude-thinking-output-cap.test.ts:109, provider argument no-op) reproduces identically on clean base 8f4b3da9: actual maxTokens=65536, budget_tokens=1536 versus expected 195072 / 131072. That test and its thinkingBudget helper are byte-identical to base and untouched by this PR.
  • Dashboard ratchet: PASS with 195 existing errors within its frozen baseline; this does not mean the whole dashboard compiles without errors.
  • Scoped ESLint, file size, cyclomatic complexity, cognitive complexity, changelog integrity, test discovery, mutation registration and PR Test Policy: PASS. Normal pre-commit hooks passed.
  • All existing touched files and package/lockfile blobs were checked against release tip a75077fa7c4fd778d7ec375691613d29c2c9a18d and remained identical to the frozen base.

Coverage Notes

The compiler diagnostics are the failure-before/fix-after proof for the type corrections. Existing translator importers verify runtime behavior; the added DSML cases characterize offsets and incomplete input. Mutation configuration changes only register existing tests. No full mutation run, full release suite, deployment or live provider calls are claimed; the merge train supplies combined release validation.

@github-actions

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

@diegosouzapw

Copy link
Copy Markdown
Collaborator Author

Closing as subsumed: the Claude translator type fix landed in #16825 and the stryker tap.testFiles registrations in #16880. The head now carries 11 duplicate stryker entries. The only new value left is the 3 DSML tests; worth a small follow-up PR if still wanted. (/merge-batch 2026-10-16)

@diegosouzapw
diegosouzapw deleted the fix/base-types-five-1016 branch October 22, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant