Repository navigation
fix(ci): restore Claude translator types and mutation test registration - #16806
Closed
diegosouzapw wants to merge 3 commits into
Closed
diegosouzapw wants to merge 3 commits into
diegosouzapw wants to merge 3 commits into
Conversation
This was referenced Oct 16, 2026
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release core typecheck reports 57 diagnostics in Claude request/response translation and the DSML parser. Explicit collection and credential types preserve the existing payload contracts; normal control-flow narrowing handles optional thinking and tools, and translator registration uses its existing optional arguments. DSML closing-tag parsing uses RegExp.exec, whose match index is required, with coverage for multiple calls, zero-offset closers and incomplete calls.
The strict mutation registration gate also reports 15 missing module/test relations. Register the 11 existing covering test files so their assertions participate in nightly mutation runs; no thresholds, mutate targets or typecheck baselines change.
Refs #15306. This addresses these specific base failures; it does not close the release-wide tracker.
Tests Added Or Updated
Validation
Frozen base 8f4b3da. Exact Node 24.21.0 and lockfile dependency versions audited on the isolated validation host (2524 installed packages, no mismatches or missing required packages).
repro-10139-claude-thinking-output-cap.test.ts:109, provider argument no-op) reproduces identically on clean base8f4b3da9: actualmaxTokens=65536,budget_tokens=1536versus expected195072/131072. That test and its thinkingBudget helper are byte-identical to base and untouched by this PR.a75077fa7c4fd778d7ec375691613d29c2c9a18dand remained identical to the frozen base.Coverage Notes
The compiler diagnostics are the failure-before/fix-after proof for the type corrections. Existing translator importers verify runtime behavior; the added DSML cases characterize offsets and incomplete input. Mutation configuration changes only register existing tests. No full mutation run, full release suite, deployment or live provider calls are claimed; the merge train supplies combined release validation.