Repository navigation
fix(ci): deliver ONNX install skip through explicit env - #16782
Merged
Merged
Conversation
Port the checkout-install policy from #16246 onto main. The shared retry action and the direct npm ci steps set ONNXRUNTIME_NODE_INSTALL=skip, and the action file joins the existing cache key.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
diegosouzapw
added a commit
that referenced
this pull request
Oct 19, 2026
Brings main's 4 post-v3.8.51 commits (#16835, #16782, #16809, #16536) into the release ancestry so PR #15083 stops being CONFLICTING and runs CI again. Tree kept identical to the release tip (da38fc4): every main-only change is already on release in a newer form — evaluateComplexityRun() in validate-release-green.mjs, the USE_VPS_BUILD_RUNNER gate in ci.yml and nightly-release-green.yml, ONNXRUNTIME_NODE_INSTALL=skip in npm-ci-retry, the 375-provider counts (main says 358), and the four unit tests whose release versions are supersets of main's. The three main-only changelog.d fragments are dropped on purpose: the reconciler credits those commits from history.
Merged
arashashrafii
pushed a commit
to arashashrafii/OmniRoute
that referenced
this pull request
Oct 24, 2026
…rence#16782) Companion for cheaper-inference#16246, already squash-merged onto `release/v3.8.52` as `fbd55a17`. This PR ports only that checkout-install delta onto `main`. - The shared `npm-ci-retry` action sets `ONNXRUNTIME_NODE_INSTALL=skip` on its install step and adds `.github/actions/npm-ci-retry/action.yml` to the existing cache key. - The same step-scoped variable is set on the direct `npm ci` steps in the workflows cheaper-inference#16246 already covered. - `action.yml` and `nightly-schemathesis.yml` had diverged on `main`, so those two files keep `main`'s shape. The release-only npm pin step and native-runtime verify step were not copied. - `tests/unit/onnx-install-env-16225.test.ts` checks `config/ci/toolchain.json` only when that file exists. `main` does not have it. `node --import tsx/esm --test tests/unit/onnx-install-env-16225.test.ts` — 29 pass / 0 fail on this commit (`24341f249b2c056bfd1347cbd970cb0e2f9930c4`), with the local npm 12.0.2. The release pin 11.15.0 is not on `main`. The branch was already even with `origin/main` (`fd95f823`) and does not change `package-lock.json`, `quality-baseline.json`, `ci.yml`, or `providerCardAudioBadge.test.tsx`. CI reds at merge time are inherited: `npm audit` critical and the vuln ratchet (66 > baseline 27) reproduce from main's lockfile, the Vitest `window is not defined` error is in that untouched UI test, and `dast-smoke` died on a runner shutdown signal. Thanks @diegosouzapw. (cherry picked from commit 5e3ee0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion for #16246, already squash-merged onto
release/v3.8.52asfbd55a17. This PR ports only that checkout-install delta ontomain. It is not merged here.npm-ci-retryaction setsONNXRUNTIME_NODE_INSTALL=skipon its install step and adds.github/actions/npm-ci-retry/action.ymlto the existing cache key.npm cisteps in the workflows fix(ci): deliver ONNX install skip flag through explicit environment #16246 already covered.action.ymlandnightly-schemathesis.ymlhad diverged onmain, so those two files keepmain's shape. The release-only npm pin step and native-runtime verify step were not copied.tests/unit/onnx-install-env-16225.test.tschecksconfig/ci/toolchain.jsononly when that file exists.maindoes not have it.Validation
node --import tsx/esm --test tests/unit/onnx-install-env-16225.test.ts— 29 pass / 0 fail on this commit (24341f249b2c056bfd1347cbd970cb0e2f9930c4), with the local npm 12.0.2. The release pin 11.15.0 is not onmain.#16225 is already closed. No file-size baseline is in this diff.
Thanks @diegosouzapw.