Repository navigation
fix(ci): deliver ONNX install skip flag through explicit environment - #16246
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Collaborator
Author
|
Fechando esta PR para esvaziar a fila aberta. A branch |
Collaborator
Author
|
Reabrindo. O fechamento foi um engano; esta PR volta para a fila de merge. A branch continua no lugar. |
diegosouzapw
added a commit
that referenced
this pull request
Oct 16, 2026
## Summary Companion for #16246, already squash-merged onto `release/v3.8.52` as `fbd55a17`. This PR ports only that checkout-install delta onto `main`. - The shared `npm-ci-retry` action sets `ONNXRUNTIME_NODE_INSTALL=skip` on its install step and adds `.github/actions/npm-ci-retry/action.yml` to the existing cache key. - The same step-scoped variable is set on the direct `npm ci` steps in the workflows #16246 already covered. - `action.yml` and `nightly-schemathesis.yml` had diverged on `main`, so those two files keep `main`'s shape. The release-only npm pin step and native-runtime verify step were not copied. - `tests/unit/onnx-install-env-16225.test.ts` checks `config/ci/toolchain.json` only when that file exists. `main` does not have it. ## Validation `node --import tsx/esm --test tests/unit/onnx-install-env-16225.test.ts` — 29 pass / 0 fail on this commit (`24341f249b2c056bfd1347cbd970cb0e2f9930c4`), with the local npm 12.0.2. The release pin 11.15.0 is not on `main`. #16225 is already closed. No file-size baseline is in this diff. The branch was already even with `origin/main` (`fd95f823`) and does not change `package-lock.json`, `quality-baseline.json`, `ci.yml`, or `providerCardAudioBadge.test.tsx`. CI reds at merge time are inherited: `npm audit` critical and the vuln ratchet (66 > baseline 27) reproduce from main's lockfile, the Vitest `window is not defined` error is in that untouched UI test, and `dast-smoke` died on a runner shutdown signal. Thanks @diegosouzapw.
arashashrafii
pushed a commit
to arashashrafii/OmniRoute
that referenced
this pull request
Oct 24, 2026
…rence#16782) Companion for cheaper-inference#16246, already squash-merged onto `release/v3.8.52` as `fbd55a17`. This PR ports only that checkout-install delta onto `main`. - The shared `npm-ci-retry` action sets `ONNXRUNTIME_NODE_INSTALL=skip` on its install step and adds `.github/actions/npm-ci-retry/action.yml` to the existing cache key. - The same step-scoped variable is set on the direct `npm ci` steps in the workflows cheaper-inference#16246 already covered. - `action.yml` and `nightly-schemathesis.yml` had diverged on `main`, so those two files keep `main`'s shape. The release-only npm pin step and native-runtime verify step were not copied. - `tests/unit/onnx-install-env-16225.test.ts` checks `config/ci/toolchain.json` only when that file exists. `main` does not have it. `node --import tsx/esm --test tests/unit/onnx-install-env-16225.test.ts` — 29 pass / 0 fail on this commit (`24341f249b2c056bfd1347cbd970cb0e2f9930c4`), with the local npm 12.0.2. The release pin 11.15.0 is not on `main`. The branch was already even with `origin/main` (`fd95f823`) and does not change `package-lock.json`, `quality-baseline.json`, `ci.yml`, or `providerCardAudioBadge.test.tsx`. CI reds at merge time are inherited: `npm audit` critical and the vuln ratchet (66 > baseline 27) reproduce from main's lockfile, the Vitest `window is not defined` error is in that untouched UI test, and `dast-smoke` died on a runner shutdown signal. Thanks @diegosouzapw. (cherry picked from commit 5e3ee0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository-controlled root dependency installs now pass
ONNXRUNTIME_NODE_INSTALL=skipdirectly to npm, so ONNX Runtime's skip decision no longer depends on npm forwarding the custom project-config key. The shared retry action and 14 direct install steps receive step-scoped env; the action itself joins the existing dependency cache hash inputs. Local POSIX and PowerShell usage is documented next to the action.Closes #16225
The legacy
.npmrckey remains for compatibility, so its warning can remain. Existing cache inputs, retries, exit propagation, native verification, workflow permissions/triggers and Electron env are preserved. Docker's checkout install already uses--ignore-scriptsand stays unchanged. Published-package consumers, separate containers, SSH deployments and tarball smoke tests are outside this checkout environment guarantee.Validation
Validated locally against
1d5128f55f3f01e1310caaa1d58046c6f15ebf62, using Node 24.21.0/npm 11.15.0, synthetic directories and offline guards:The separate
typecheck:noimplicit:coregate remains exit 2, with four TS7053 diagnostics inopen-sse/utils/proxyDispatcherCache.ts(173/175) andsrc/lib/db/databaseSettings.ts(302/303). Its full TypeScript 6.0.3 input inventory contains 1,627 versioned source inputs plus 11 tracked resolution metadata files, all byte-identical to base1d512; 826 dependency inputs come from the same retained dependency tree. No generated/untracked input or changed PR path enters that project. This is an inherited-by-input-equivalence attribution accepted during review, not a new compiler execution on a pristine base, and not a passing strict gate. No baseline was relaxed.The initial Docker-control selector mistake and an unsuccessful intermediate fixture-edit attempt remain recorded separately from the valid RED/GREEN pairs. No startup crash, 300 MB payload, future npm release behavior, full coverage, build or hosted CI result was reproduced or claimed.
Historical base-red context: #15306 remains open. Its six recorded release-green outcomes are unit-suite timeout, Vitest MCP audit shutdown failure, integration timeout, package-artifact timeout, downstream tarball smoke skipped because its artifact was absent, and an AI-attribution Git-range failure. Those outcomes were not reproduced anew here; the downstream skip is not an independent executed test failure. This PR does not claim the full release is green.