fix(combo): skip the redundant second LKGP write on matching combo key

changelog.d/fixes/15432-lkgp-intra-request-ttl.md

@@ -0,0 +1 @@
+- **fix(combo):** skip the redundant second LKGP write when a combo success already pins the combo-level key ([#15432](https://github.com/diegosouzapw/OmniRoute/pull/15432)) — thanks @maxmad64bis

open-sse/services/combo/recordLkgpPin.ts

@@ -24,9 +24,14 @@ async function writePins(
   setLKGPFn: SetLkgp | undefined
 ): Promise<void> {
   const set = setLKGPFn ?? (await import("@/lib/db/settings")).setLKGP;
+  const comboKey = comboId || comboName;
+  if (comboKey === comboName) {
+    await set(comboName, comboKey, provider, connectionId);
+    return;
+  }
   await Promise.all([
     set(comboName, executionKey, provider, connectionId),
-    set(comboName, comboId || comboName, provider, connectionId),
+    set(comboName, comboKey, provider, connectionId),
   ]);
 }
 

tests/unit/combo/record-lkgp-pin.test.ts

@@ -156,3 +156,52 @@ test("writer calls carry the connection id through (absent stays absent)", async
   });
   assert.deepEqual(seen, [undefined, undefined]);
 });
+
+test("records a single combo-level pin when the combo id matches the combo name", async () => {
+  // Pin store standing in for the persisted LKGP namespace; the read below is
+  // the `getLKGP(comboName, comboId || comboName)` equivalent the routing
+  // readers use.
+  const store = new Map<string, { provider: string; connectionId?: string }>();
+  const calls: Array<[string, string, string, string | undefined]> = [];
+  const { warnings, log } = captureWarn();
+  await recordLkgpPin({
+    comboName: "combo-a",
+    executionKey: "ek-7",
+    comboId: "combo-a",
+    provider: "openai",
+    connectionId: "conn-1",
+    log,
+    tag: "COMBO",
+    setLKGP: async (comboName, modelKey, provider, connectionId) => {
+      calls.push([comboName, modelKey, provider, connectionId]);
+      store.set(`${comboName}:${modelKey}`, { provider, connectionId });
+    },
+  });
+  assert.deepEqual(warnings, []);
+  assert.equal(calls.length, 1);
+  assert.deepEqual(calls, [["combo-a", "combo-a", "openai", "conn-1"]]);
+  assert.equal(store.get("combo-a:combo-a")?.provider, "openai");
+});
+
+test("records a single combo-level pin when the combo id is missing", async () => {
+  const store = new Map<string, { provider: string; connectionId?: string }>();
+  const calls: Array<[string, string, string, string | undefined]> = [];
+  const { warnings, log } = captureWarn();
+  await recordLkgpPin({
+    comboName: "combo-a",
+    executionKey: "ek-7",
+    comboId: null,
+    provider: "openai",
+    connectionId: "conn-1",
+    log,
+    tag: "COMBO",
+    setLKGP: async (comboName, modelKey, provider, connectionId) => {
+      calls.push([comboName, modelKey, provider, connectionId]);
+      store.set(`${comboName}:${modelKey}`, { provider, connectionId });
+    },
+  });
+  assert.deepEqual(warnings, []);
+  assert.equal(calls.length, 1);
+  assert.deepEqual(calls, [["combo-a", "combo-a", "openai", "conn-1"]]);
+  assert.equal(store.get("combo-a:combo-a")?.provider, "openai");
+});