Repository navigation
fix(combo): skip the redundant second LKGP write on matching combo key - #15432
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
maxmad64bis
force-pushed
the
fix/lkgp-intra-request-ttl
branch
from
October 3, 2026 09:57
f709556 to
fb08e61
Compare
Two setLKGP calls per success became one when comboId matches comboName; proven by unit RED/GREEN plus a disposable-DB run.
maxmad64bis
force-pushed
the
fix/lkgp-intra-request-ttl
branch
from
October 3, 2026 10:40
fb08e61 to
743f68f
Compare
5 tasks done
maxmad64bis
marked this pull request as ready for review
October 3, 2026 16:10
diegosouzapw
merged commit Oct 6, 2026
84af48a
into
cheaper-inference:release/v3.8.52
110 of 154 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combo runs that saved the provider choice twice when the combo id matched the combo name now save it once. The dropped write carried the same provider and connection but was never read back. Pinned combos resolve the same provider as before.
Related Issues
Validation
npm run lintTests Added Or Updated
tests/unit/combo/record-lkgp-pin.test.ts— two new cases for matching id and missing id, each asserting a single combo-level write on the read key plus a read-back of the stored provider; the key assertion guards the direction of the fix because a count-only check passes with either key kept.Coverage Notes
open-sse/services/combo/recordLkgpPin.ts— covered bytests/unit/combo/record-lkgp-pin.test.ts(existing distinct-keys case plus the two new matching-key cases).Reviewer Notes