Repository navigation
fix(sse): restore the reselectedProxy declaration dropped by the #14659 merge - #14865
Merged
diegosouzapw merged 2 commits intoSep 25, 2026
Merged
Conversation
… merge The release-merge conflict resolution for #14659 kept both uses of reselectedProxy in OpencodeExecutor but dropped its declaration, so open-sse/executors/opencode.ts failed tsc (TS2304) and a proxy-less dispatch threw ReferenceError at runtime. Restore the declaration and reset the refusal memory between the pool-reselect cases, since PROXY_SKIP_RECENTLY_FAILED is now on by default (#14688). opencode-429-pool-reselect: 0/6 on the broken tip, 6/6 with the fix.
…de-reselected-proxy-decl # Conflicts: # config/quality/file-size-baseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release-merge conflict resolution done during the #14659 rework (squash 3d8a9a2) kept both uses of
reselectedProxyinOpencodeExecutorbut dropped its declaration. On the current tipopen-sse/executors/opencode.tsfails tsc with TS2304 and a proxy-less opencode dispatch (account.proxy ?? reselectedProxy) throwsReferenceErrorat runtime.tests/unit/opencode-429-pool-reselect.test.tsnow resets the proxy refusal memory inbeforeEach: withPROXY_SKIP_RECENTLY_FAILEDon by default (fix(proxies): skip recently failed proxies by default #14688) a 429 from one case set its proxy aside for the next case.config/quality/file-size-baseline.json: opencode.ts ceiling +5 (the restored lines), dated annotation.Validation
opencode-429-pool-reselect0/6 (ReferenceError). Green with this change: 6/6, plusopencode-proxy-refusal-memory12/12.tsc -p open-sse/tsconfig.json: 0 errors in opencode.ts (2x TS2304 on the tip);check:open-sse-typecheckOK;check-file-sizegreen; eslint clean on the touched files.