Repository navigation
fix(sse): share applied proxy capture across duplicated fetch modules - #14620
Merged
diegosouzapw merged 1 commit intoSep 24, 2026
Conversation
maxmad64bis
force-pushed
the
fix/applied-proxy-shared-context
branch
from
September 23, 2026 10:11
27fcd48 to
5e2ff35
Compare
maxmad64bis
marked this pull request as ready for review
September 23, 2026 10:51
This was referenced Sep 23, 2026
Collaborator
|
Good catch on the module-duplication trap — keying the |
diegosouzapw
merged commit Sep 24, 2026
699738b
into
cheaper-inference:release/v3.8.51
17 of 25 checks passed
5 tasks done
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proxy journal keeps one capture context per
proxyFetchmodule copy, so when the server bundle serves a dispatch from a copy that did not open the capture, the provider status actually received is never recorded. This change shares the capture context across duplicated module copies, so the journal can tell a received provider status apart from a local failure no matter which server copy serves the dispatch.Related Issues
Related to #13580
Validation
npm run lintTests Added Or Updated
tests/unit/proxy-fetch-applied-context.test.ts(new, 3 cases: single-copy trap that passes before and after, two-copy captureundefined !== 429RED then GREEN, sequential isolation with throw leaving no stale status).tests/unit/proxyfetch-upstream-status-capture.test.ts(9/9),tests/unit/proxy-fetch.test.ts(9/9),tests/unit/proxy-logs-upstream-status.test.ts(4/4).Coverage Notes
Reviewer Notes
open-sse/utils/proxyFetch.ts1287 → 1294 (+7, shared key + store type + lazy getter and four one-line call-site swaps; irreducible at the single store-identity chokepoint), recorded as_rebaseline_2026_09_23_applied_proxy_shared_contextinconfig/quality/file-size-baseline.json.typecheck:coreshows one error insrc/lib/services/cliproxyAccountHealth.ts(157,5)(TS2322) pluscheck-open-sse-typecheckonopen-sse/executors/auggie.ts(TS2769/TS18047); both reproduce on the pure base and touch no file in this PR — inherited, non-blocking.API Route Typecheckreports 4 diagnostics inopen-sse/executors/auggie.ts(TS2769/TS18047) andsrc/app/api/v1/combos/projectCombo.ts(TS2459/TS2724); both files are unchanged since the merge-base and the same 4 lines fail on same-base PRs test(sse): lock per-key ceiling 429 out of neighbor cooldown scope #14581/fix(sse): serve the stored 429 instead of re-sending refused requests #14588, so inherited via 🔴 Release branch not green: release/v3.8.51 #14547 and non-blocking.Recensement (upstream positions)
appliedProxyContext,Symbol.for+ capture): no duplicate found.