Skip to content

test(sse): lock per-key ceiling 429 out of neighbor cooldown scope - #14581

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/token-limit-neighbor-cooldown-lock
Sep 24, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/token-limit-neighbor-cooldown-lock

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #14547

Summary

A per-key token ceiling rejection (HTTP 429) now provably leaves both the serving connection and same-egress neighbors untouched: the decision skips the cooldown path and the client still gets its 429. This locks in the behavior introduced by #13606 with a neighbor-scoped regression test. No default or behavior change.

Related Issues

Validation

  • Change type: sse
  • Focused tests and category gates from the golden path
  • npm run lint — ESLint on the touched files is clean (exit 0 with repo suppressions); the full run is red on the base (🔴 Release branch not green: release/v3.8.51 #14547 — cliproxyAccountHealth.ts TS2322, file outside this diff, identical on base)
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

  • tests/unit/per-key-ceiling-skips-neighbor-cooldown.test.ts (new, 1 test): two connections sharing one egress address, exact Tier-2 refusal (429 + TOKEN_LIMIT_EXCEEDED) — serving and sibling stay active, client status stays 429. No production code changed, so no existing test needed updating.

Coverage Notes

  • N/A — test-only change; no src/, open-sse/, electron/, or bin/ production file touched. The test pins the skip contract so a future regression of the shared skip table fails here first.

Reviewer Notes

@maxmad64bis
maxmad64bis force-pushed the fix/token-limit-neighbor-cooldown-lock branch from 9539fb2 to b27c6cd Compare September 23, 2026 01:12
@maxmad64bis
maxmad64bis marked this pull request as ready for review September 23, 2026 01:19
@maxmad64bis
maxmad64bis force-pushed the fix/token-limit-neighbor-cooldown-lock branch from b27c6cd to 0b710ca Compare September 23, 2026 02:08
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for locking this in — a dedicated neighbor-scoped regression test for the per-key
ceiling/cooldown-skip contract from #13606 is exactly the kind of coverage that keeps this area
honest as it evolves. Clean, single-purpose, no production change. Looks merge-ready.

@diegosouzapw
diegosouzapw merged commit 99b4e62 into cheaper-inference:release/v3.8.51 Sep 24, 2026
9 of 16 checks passed
@maxmad64bis
maxmad64bis deleted the fix/token-limit-neighbor-cooldown-lock branch September 24, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants