Repository navigation
test(sse): lock per-key ceiling 429 out of neighbor cooldown scope - #14581
Merged
diegosouzapw merged 1 commit intoSep 24, 2026
Conversation
maxmad64bis
force-pushed
the
fix/token-limit-neighbor-cooldown-lock
branch
from
September 23, 2026 01:12
9539fb2 to
b27c6cd
Compare
maxmad64bis
marked this pull request as ready for review
September 23, 2026 01:19
maxmad64bis
force-pushed
the
fix/token-limit-neighbor-cooldown-lock
branch
from
September 23, 2026 02:08
b27c6cd to
0b710ca
Compare
5 tasks done
maxmad64bis
force-pushed
the
fix/token-limit-neighbor-cooldown-lock
branch
from
September 23, 2026 09:08
0b710ca to
fcf79e1
Compare
This was referenced Sep 23, 2026
Collaborator
|
Thanks for locking this in — a dedicated neighbor-scoped regression test for the per-key |
diegosouzapw
merged commit Sep 24, 2026
99b4e62
into
cheaper-inference:release/v3.8.51
9 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A per-key token ceiling rejection (HTTP 429) now provably leaves both the serving connection and same-egress neighbors untouched: the decision skips the cooldown path and the client still gets its 429. This locks in the behavior introduced by #13606 with a neighbor-scoped regression test. No default or behavior change.
Related Issues
Validation
npm run lint— ESLint on the touched files is clean (exit 0 with repo suppressions); the full run is red on the base (🔴 Release branch not green: release/v3.8.51 #14547 —cliproxyAccountHealth.tsTS2322, file outside this diff, identical on base)Tests Added Or Updated
tests/unit/per-key-ceiling-skips-neighbor-cooldown.test.ts(new, 1 test): two connections sharing one egress address, exact Tier-2 refusal (429+TOKEN_LIMIT_EXCEEDED) — serving and sibling stay active, client status stays 429. No production code changed, so no existing test needed updating.Coverage Notes
src/,open-sse/,electron/, orbin/production file touched. The test pins the skip contract so a future regression of the shared skip table fails here first.Reviewer Notes
local-token-budget-429-skips-cooldown6/6,egress-ip-lock-1088017/17).✗lines (auggie TS2769/TS18047, chatCore TS2304, projectCombo TS2459/TS2724) reproduce on the bare base (git diff $mbempty on all three files), same family as third-party fix(proxies): derive bulk import statuses from shared registry #14579 on the previous base. Base-red 🔴 Release branch not green: release/v3.8.51 #14547 cited.✖lists contain zero hits of this PR's test on all 4 shards (local re-runs 1/1 + neighbors 6/6 + 17/17 green); Fast Quality Gates✗lines match the base pattern (auggie,intelligentRouting.ts TS2698, mutation drift over third-party modules — this PR's own test is registered, 0per-key-ceilinghits locally); Docs Gates env-contract gap is untouched by this PR (git diff $mbempty on docs). Base-red 🔴 Release branch not green: release/v3.8.51 #14547 cited.