Skip to content

fix(tests): update stale GLM arity assertion broken by #12925 #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
Closed

fix(tests): update stale GLM arity assertion broken by #12925 #13402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/unit/glm-sse-transform-arity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ import { dirname, join } from "node:path";

/**
* GLM's translateSseResponse used to pass a 16th positional (65536) to
* createSSETransformStreamWithLogger. The helper only has 15 parameters
* (last is requestToolIdentityMap) — tsc reports TS2554 and the number
* never reached TransformStream.
* createSSETransformStreamWithLogger. #12925 legitimised the buffer-size
* argument as a named constant (GLM_STREAM_BUFFER_BYTES), so the call now
* ends with that constant instead of suppressThinkClose.
*
* Guard the call site in source: no 65536, last arg is suppressThinkClose.
* Guard the call site in source: no hardcoded 65536 literal, last arg is
* GLM_STREAM_BUFFER_BYTES (the named constant introduced by #12925).
*/
const root = join(dirname(fileURLToPath(import.meta.url)), "..", "..");

Expand Down Expand Up @@ -47,5 +48,5 @@ test("GLM translateSseResponse does not pass a 16th positional to the stream hel
assert.ok(callAt >= 0);
const call = extractParens(body, callAt + "createSSETransformStreamWithLogger".length);
assert.equal(/65536/.test(call), false, `dead 16th arg still present:\n${call}`);
assert.match(call, /suppressThinkClose\s*\)\s*$/);
assert.match(call, /GLM_STREAM_BUFFER_BYTES\s*\)\s*$/, "call should end with GLM_STREAM_BUFFER_BYTES, not a hardcoded literal");
});
Loading