Repository navigation
fix(tests): update stale GLM arity assertion broken by #12925 - #13402
Closed
KooshaPari wants to merge 1 commit into
Closed
KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
…nce#12925 cheaper-inference#12925 legitimised the buffer-size argument in GLM's createSSETransformStreamWithLogger call, replacing the hardcoded 65536 with the named constant GLM_STREAM_BUFFER_BYTES. The test in glm-sse-transform-arity.test.ts still asserted the call ended with suppressThinkClose, which is no longer the last argument. Update the assertion to expect GLM_STREAM_BUFFER_BYTES as the final argument while keeping the hardcoded-65536 dead-literal guard from cheaper-inference#12770. Fixes cheaper-inference#13319
Collaborator
|
Thanks! The release branch already rewrote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/glm-sse-transform-arity.test.tsfails onrelease/v3.8.51base ataf49d4972, independently of any PR. Every PR targeting this base inherits a red Unit Tests job.Root cause
#12770added an arity guard asserting the GLM call ends withsuppressThinkClose.#12925then legitimised the buffer-size argument (GLM_STREAM_BUFFER_BYTES), so the call now ends with three more positionals aftersuppressThinkClose. The second assertion is stale.Fix
Update the assertion to expect
GLM_STREAM_BUFFER_BYTESas the final argument while keeping the hardcoded65536dead-literal guard from#12770.Also updated the JSDoc to explain the change.
Tests
Related
Fixes #13319