Repository navigation
feat(codex): surface minimum client version guidance - #12893
diegosouzapw merged 2 commits into
Conversation
69390e8 to
36439ba
Compare
|
The API Route Typecheck failure was not caused by this PR — |
|
Pushed the remaining gate fixes on top of the feature commit:
Local validation: api-typecheck OK, open-sse-typecheck OK, file-size OK, docs-sync/docs-counts/changelog-integrity OK, pack-policy OK, mutation-test-coverage OK, codex/glm targeted suites 59/59. |
3753611 to
64ee1c3
Compare
|
Rebased onto the current release tip and slimmed the branch to three commits:
The earlier base-red cherry-picks (stream highWaterMark, chatCore narrowing, doc counts) are dropped — the maintainers landed equivalents in #12963/#12970/#12990. Full gate suite on this tree: api-typecheck, open-sse-typecheck, file-size, docs-sync, changelog-integrity, pack-policy, mutation-coverage all green; codex suites 40/40. |
|
Merged the current release tip into the branch and re-synced the migration count (171→172, all 41 llm.txt mirrors) so CI evaluates a fresh tree. On this tree the only remaining red I can see is |
|
Nice diagnostic — the "why is this model missing" message is genuinely useful, and I ran both |
|
Thank you for the review — glad the diagnostic message lands well, and appreciate you running the suites at the head. Understood on both notes: the 171→172 docs hunks are stale base leftovers and will be dropped (left to the docs-sync generator) whenever the branch next moves, and we'll hold off rebasing until the sequencing with #13224/#12933 is decided. Happy to rework the compatibility-warning logic onto #12933's candidate/active classification if that's the shape it takes — just ping here. |
|
Re-homed to |
0f38830 to
c73b2a1
Compare
|
Thanks for the guidance on sequencing this with the Codex discovery changes. I have now adapted the patch to the current The warning now follows the selected account/catalog candidates and the effective refreshed HTTP client version. It preserves the new reasoning metadata, live account membership, empty all-filtered results, and cache fallback ordering. I also removed the obsolete baseline/docs changes. The focused regressions pass (71 tests), and the changed-file and provider gates pass. I reproduced the existing reasoning/golden failures on the unchanged base and documented those, together with the inherited full-lint/typecheck limitations, in the PR description. The update is ready for your review when it fits the release queue. Thank you! |
|
Thanks again for the sequencing guidance. I have now incorporated the current The former lint, dashboard typecheck, internal-service-auth, and OpenAI→Claude failures are resolved after bringing in the upstream fixes. Full lint, the core/dashboard type gates, provider and file-size gates, mutation-test registration, docs version sync, and commit hooks pass locally. Expanded tests pass 103/104; the remaining golden failure has the exact same assertion diff on an isolated unchanged base. I also checked the generator/workflow reds against that exact base: the stale-skills report and five scheduled-job guard findings are identical, so they remain inherited #15306 work rather than extra fixes in this feature PR, as requested by the contribution guide. The description records these boundaries and leaves broad build/i18n verification to the new CI run. The update is ready for review when it fits the release queue. Thank you! |
28e2a15
into
cheaper-inference:release/v3.8.52
|
Thanks @guanbear — Codex model discovery names the models that need a newer client profile and says which version the catalog requires. This is in the upcoming release. |
Summary
Explain ChatGPT/Codex models withheld because their
minimal_client_versionexceeds OmniRoute's effective HTTP client profile. The warning reports the affected IDs, current version, highest required minimum, and recovery steps: refresh discovery, upgrade OmniRoute, or use a temporaryCODEX_CLIENT_VERSIONoverride only when the release is otherwise protocol-compatible.This applies to the HTTP
codexprovider. Installing a standalone Codex CLI is relevant only to the separatecodex-app-serverprovider.Integration with the current release branch
Updated the focused patch on
release/v3.8.52at4ea24a2f8e1f, following the sequencing advice in this thread:requires-newer-clientreason instead of introducing a second compatibility policy.Related to #12761; complements #12827 and #12759.
Validation
typecheck:core, dashboard TypeScript ratchet, provider consistency/assets, file-size/test-file-size, mutation-test registration, docs version synchronization, changelog integrity, formatting, andgit diff --checkpassed.4ea24a2f8e1fbase. The previously failing internal-service-auth and OpenAI→Claude tests now pass after incorporating upstream fixes.Inherited base failures
4ea24a2f8e1f:check:agent-skills-syncreports the same 20 stale generated skills on both trees. The generator sources, OpenAPI/CLI inputs, and generated skills are not changed by this feature PR. No unrelated generated instruction edits are included.docker-publish.ymljobs on both trees. The complete local workflow audit is unavailable because actionlint/zizmor are not installed; no full local workflow-audit pass is claimed.imageRegistryinto server-only modules. The incorporated release contains the upstream image-registry split (fix(imageRegistry): split data from flag-gated logic to avoid client bundle leak (#10692) #15791); production build verification remains with the new CI run.The full unit/Vitest/coverage/build suites remain CI's responsibility under the contribution golden path. This update does not claim the release branch is green.