Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js app router migration #1279

Merged
merged 50 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
42b4972
base layout + migrate head
annarhughes Jan 15, 2025
aab17f9
migrate font and language
annarhughes Jan 15, 2025
44f9e21
layout support
annarhughes Jan 20, 2025
7f07df6
rename pages folder
annarhughes Jan 20, 2025
73e841e
use next/navigation
annarhughes Jan 21, 2025
33bb9c4
redux + storyblok changes
annarhughes Jan 21, 2025
379fde4
upgrade next.js + add MUI + layout comps
annarhughes Jan 21, 2025
4a8854d
firebase setup
annarhughes Jan 21, 2025
8734eb3
use routing hooks
annarhughes Jan 21, 2025
6bc8a74
fix font build error
annarhughes Jan 21, 2025
dc1f54c
fix JSX export error
annarhughes Jan 21, 2025
9cb6b60
fix useParams import
annarhughes Jan 21, 2025
48d0197
fix build errors
annarhughes Jan 21, 2025
a48270c
new relic setup + error page
annarhughes Jan 27, 2025
a2f6cb5
integrated rollbar
annarhughes Jan 27, 2025
ee375d4
refactor google analytics
annarhughes Jan 27, 2025
899c7df
minor fix intl + favicon
annarhughes Jan 27, 2025
6d87674
use import alias @
annarhughes Jan 28, 2025
b7e34cd
migrate pages excl refactor
annarhughes Jan 28, 2025
aebb48a
fix middleware dev cmd
annarhughes Jan 29, 2025
23ea693
welcome partner page
annarhughes Jan 29, 2025
2e46158
courses list page
annarhughes Jan 29, 2025
9c80e32
refactor getStoryblokStories
annarhughes Jan 29, 2025
e181e63
course + session pages
annarhughes Jan 29, 2025
d2c6d68
auth + account pages
annarhughes Jan 29, 2025
5f19765
admin + therapy pages
annarhughes Jan 29, 2025
845cbdc
shorts + conversations
annarhughes Jan 29, 2025
5d1fdcc
messaging + team pages
annarhughes Jan 29, 2025
5efadfb
fix related course for shorts
annarhughes Jan 29, 2025
2b4df00
fix build errors
annarhughes Jan 29, 2025
8220dd1
pages components folder
annarhughes Jan 29, 2025
434de05
rm unused code and exports
annarhughes Jan 30, 2025
103adb0
move folders into lib
annarhughes Jan 30, 2025
193b7d5
remove no-cache
annarhughes Jan 30, 2025
eb6aeda
fix 404 + locale issues
annarhughes Jan 30, 2025
dbedaa4
mv components top lv
annarhughes Jan 30, 2025
f2b770c
generate metadata + split pages
annarhughes Jan 30, 2025
af4114f
fix tests
annarhughes Jan 30, 2025
ce6a216
run cypress tests
annarhughes Feb 3, 2025
6b10d97
rm seo_description params comps
annarhughes Feb 3, 2025
6eea673
improve params syntax
annarhughes Feb 3, 2025
c29ca4f
missing useEffect deps
annarhughes Feb 3, 2025
0a3f5d5
missing translations
annarhughes Feb 3, 2025
fa33aae
fix cypress tests initial
annarhughes Feb 3, 2025
fd0d20f
fix session build error
annarhughes Feb 3, 2025
97f66d8
fix auth guard
annarhughes Feb 3, 2025
8237374
force-dynamic on welcome page
annarhughes Feb 3, 2025
499255e
fix dynamic rendering + tests
annarhughes Feb 3, 2025
0c35efe
action handler fixes
annarhughes Feb 3, 2025
6b44850
attempt fix session test
annarhughes Feb 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .github/workflows/cypress-release-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Cypress release tests

on:
push:
branches: [develop, dependabot/**, '*test*']
branches: [develop, dependabot/**, '*test*', 'app-migration-layouts']

jobs:
# vercel will redeploy the develop/staging app on creating a PR to main
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET: ${{ secrets.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET }}
NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID}}
NEXT_PUBLIC_FIREBASE_APP_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_APP_ID }}
NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID }}
NEXT_PUBLIC_GOOGLE_ANALYTICS_ID: ${{ secrets.NEXT_PUBLIC_GOOGLE_ANALYTICS_ID }}
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_BASE_URL: ${{ needs.wait-for-vercel-deployment.outputs.preview_url }}
CYPRESS_MAIL_SLURP_API_KEY: ${{secrets.CYPRESS_MAIL_SLURP_API_KEY}}
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET: ${{ secrets.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET }}
NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID}}
NEXT_PUBLIC_FIREBASE_APP_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_APP_ID }}
NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID }}
NEXT_PUBLIC_GOOGLE_ANALYTICS_ID: ${{ secrets.NEXT_PUBLIC_GOOGLE_ANALYTICS_ID }}
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_BASE_URL: ${{ needs.wait-for-vercel-deployment.outputs.preview_url }}
CYPRESS_SUPER_ADMIN_EMAIL: ${{secrets.CYPRESS_SUPER_ADMIN_EMAIL}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cypress-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET: ${{ secrets.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET }}
NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID}}
NEXT_PUBLIC_FIREBASE_APP_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_APP_ID }}
NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID: ${{ secrets.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID }}
NEXT_PUBLIC_GOOGLE_ANALYTICS_ID: ${{ secrets.NEXT_PUBLIC_GOOGLE_ANALYTICS_ID }}
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
CYPRESS_BASE_URL: ${{ secrets.NEXT_PUBLIC_BASE_URL }}
CYPRESS_MAIL_SLURP_API_KEY: ${{secrets.CYPRESS_MAIL_SLURP_API_KEY}}
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ yarn-error.log*
cypress.env.json
/.nyc_output

# Partytown
/public/~partytown

# New Relic
newrelic_agent.log

Expand Down
77 changes: 77 additions & 0 deletions app/[locale]/[slug]/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
import StoryblokPage, { StoryblokPageProps } from '@/components/storyblok/StoryblokPage';
import { getStoryblokApi, ISbStoriesParams } from '@storyblok/react/rsc';

import { routing } from '@/i18n/routing';
import { getStoryblokStory } from '@/lib/storyblok';
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { notFound } from 'next/navigation';

export const dynamicParams = false;
export const revalidate = 14400; // invalidate every 4 hours

type Params = Promise<{ locale: string; slug: string }>;

async function getStory(locale: string, slug: string) {
return await getStoryblokStory(slug, locale);
}

export async function generateMetadata({ params }: { params: Params }) {
const { locale, slug } = await params;
const story = await getStory(locale, slug);

if (!story) return;

return generateMetadataBasic({
title: story.content.title,
description: story.content.seo_description,
});
}

export async function generateStaticParams() {
let paths: { slug: string; locale: string }[] = [];

const locales = routing.locales;
const storyblokApi = getStoryblokApi();

let sbParams: ISbStoriesParams = {
version: 'published',
};

const { data } = await storyblokApi.get('cdn/links/', sbParams);

const excludePaths: string[] = [
'home',
'welcome',
'meet-the-team',
'courses',
'about-our-courses',
'messaging',
'shorts',
'conversations',
];

Object.keys(data.links).forEach((linkKey) => {
const story = data.links[linkKey];
const slug = story.slug;
const basePath = slug.split('/')[0];

if (story.is_folder || !story.published || excludePaths.includes(basePath)) return;

for (const locale of locales) {
paths.push({ slug, locale });
}
});
return paths;
}

export default async function Page({ params }: { params: Params }) {
const { locale, slug } = await params;

const story = await getStory(locale, slug);

if (!story) {
notFound();
}

return <StoryblokPage {...(story.content as StoryblokPageProps)} />;
}
18 changes: 18 additions & 0 deletions app/[locale]/account/about-you/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import AboutYouPage from '../../../../components/pages/AboutYouPage';

type Params = Promise<{ locale: string }>;

export const dynamic = 'force-dynamic';

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Account.aboutYou' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <AboutYouPage />;
}
16 changes: 16 additions & 0 deletions app/[locale]/account/apply-a-code/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import ApplyACodePage from '@/components/pages/ApplyACodePage';
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Account.applyCode' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <ApplyACodePage />;
}
16 changes: 16 additions & 0 deletions app/[locale]/account/disable-service-emails/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import DisableServiceEmailsPage from '../../../../components/pages/DisableServiceEmailsPage';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Account.disableServiceEmails' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <DisableServiceEmailsPage />;
}
16 changes: 16 additions & 0 deletions app/[locale]/account/settings/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import SettingsPage from '@/components/pages/SettingsPage';
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Account.accountSettings' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <SettingsPage />;
}
20 changes: 20 additions & 0 deletions app/[locale]/action-handler/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use client';

import { useRouter } from '@/i18n/routing';
import { notFound, redirect, useSearchParams } from 'next/navigation';

export const dynamic = 'force-dynamic';

// Page to handle redirects from external tools. E.g. firebase auth emails redirect to /action-handler?mode=resetPassword&oobCode....
export default function Page() {
const router = useRouter();
const searchParams = useSearchParams();

let modeParam = searchParams.get('mode');

if (modeParam && modeParam === 'resetPassword') {
redirect(`/auth/reset-password?oobCode=${searchParams.get('oobCode')}`);
} else {
notFound();
}
}
16 changes: 16 additions & 0 deletions app/[locale]/admin/dashboard/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import AdminDashboardPage from '../../../../components/pages/AdminDashboardPage';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Admin' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <AdminDashboardPage />;
}
16 changes: 16 additions & 0 deletions app/[locale]/auth/login/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import LoginPage from '../../../../components/pages/LoginPage';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Auth.login' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <LoginPage />;
}
18 changes: 18 additions & 0 deletions app/[locale]/auth/register/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import RegisterPage from '../../../../components/pages/RegisterPage';

type Params = Promise<{ locale: string }>;

export const dynamic = 'force-dynamic';

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Auth.register' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <RegisterPage />;
}
18 changes: 18 additions & 0 deletions app/[locale]/auth/reset-password/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getTranslations } from 'next-intl/server';
import ResetPasswordPage from '../../../../components/pages/ResetPasswordPage';

export const dynamic = 'force-dynamic';

type Params = Promise<{ locale: string }>;

export async function generateMetadata({ params }: { params: Params }) {
const { locale } = await params;
const t = await getTranslations({ locale, namespace: 'Auth.resetPassword' });

return generateMetadataBasic({ title: t('title') });
}

export default function Page() {
return <ResetPasswordPage />;
}
83 changes: 83 additions & 0 deletions app/[locale]/conversations/[slug]/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
import StoryblokResourceConversationPage, {
StoryblokResourceConversationPageProps,
} from '@/components/storyblok/StoryblokResourceConversationPage';
import { routing } from '@/i18n/routing';
import { getStoryblokStory } from '@/lib/storyblok';
import { generateMetadataBasic } from '@/lib/utils/generateMetadataBase';
import { getStoryblokApi, ISbStoriesParams } from '@storyblok/react/rsc';
import { getTranslations } from 'next-intl/server';
import { notFound } from 'next/navigation';

export const dynamicParams = false;
export const revalidate = 14400; // invalidate every 4 hours

type Params = Promise<{ locale: string; slug: string }>;

async function getStory(locale: string, slug: string) {
return await getStoryblokStory(`conversations/${slug}`, locale, {
resolve_relations: ['resource_conversation.related_content'],
});
}

export async function generateMetadata({ params }: { params: Params }) {
const { locale, slug } = await params;
const t = await getTranslations({ locale, namespace: 'Resources' });
const story = await getStory(locale, slug);

if (!story) return;

return generateMetadataBasic({
title: story.content.name,
titleParent: t('conversations'),
description: story.content.seo_description,
});
}

export async function generateStaticParams() {
let paths: { slug: string; locale: string }[] = [];

const locales = routing.locales;
const storyblokApi = getStoryblokApi();

let sbParams: ISbStoriesParams = {
version: 'published',
starts_with: 'conversations/',
filter_query: {
component: {
in: 'resource_conversation',
},
},
};

const { data } = await storyblokApi.get('cdn/links/', sbParams);

Object.keys(data.links).forEach((linkKey) => {
const story = data.links[linkKey];

if (!story.slug || !story.published) return;

const slug = story.slug.split('/')[1];

for (const locale of locales) {
paths.push({ slug, locale });
}
});
return paths;
}

export default async function Page({ params }: { params: Params }) {
const { locale, slug } = await params;

const story = await getStory(locale, slug);

if (!story) {
notFound();
}

return (
<StoryblokResourceConversationPage
{...(story.content as StoryblokResourceConversationPageProps)}
storyId={story.id}
/>
);
}
Loading
Loading