WIP: App router migration #1279
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make and why did you make them?
WIP of next.js app router migration, which requires significant changes to app structure and logic, including how internationalisation and integrations are configured.
See the following guides related to the app router migration:
Next.js migration guide
MUI app router guide
Redux app router guide - see note on potential redundancy
next-intl app router guide
The approach is to migrate the entire app in this PR and test extensively before release. An incremental migration was preferred but was costing more time to make integrations (next-intl, MUI, Redux) work with both pages and app router.
Note that server components and next.js data fetching has not yet been fully implemented. Whilst the app has been moved to the app router structure and uses the latest packages and patterns, we haven't yet split our pages and components into client and server components - this will be completed incrementally later.
We should also consider removing Redux in favour of next.js data fetching and available state such as context - the latest changes in app router make Redux less effective or necessary. MUI is adding support for RSC and we will need to refactor how we use it (likely using the new PigmentCSS option) as part of the splitting client and server components.