Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy dist files in release tags (bower support) #3223

Merged
merged 5 commits into from
Sep 3, 2016

Conversation

simonbrunel
Copy link
Member

@simonbrunel simonbrunel commented Aug 28, 2016

Bring back to life bower.json and dist files in the repository: the only (big) difference with before is that dist/*.js files are not in any branches but only in tags. They are automatically generated from the new release branch and pushed along the created tag. @chartjs/contributors: can you please read the Release-Process.md file for details and, if needed, propose a better wording and report typos.

Related issues: #3033, #3081, #3182, #3145, #3216

@etimberg
Copy link
Member

I didn't notice anything in these changes that looks wrong. I like the docs on how to make a release.

Add a new Travis deploy task to push dist/*.js and bower.json files into tag sources:
- requires Travis GITHUB_AUTH_TOKEN and GITHUB_AUTH_EMAIL environment variables
- skipped if not built from the "release" branch
- release.sh must be executable (see comment)
- reads tag version from package.json
- fails if tag already exists
Secure values are now read from environment variables defined in the repository settings: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
@panzarino
Copy link
Contributor

+1 to merge, great work @simonbrunel

@simonbrunel
Copy link
Member Author

simonbrunel commented Sep 3, 2016

Merging that PR since it contains some gulp change I need for another PR, but still waiting news from Centralway about transferring the chart.js package name (see bower/registry#219).

Related issue: #1562

@simonbrunel simonbrunel merged commit 4cbff02 into chartjs:master Sep 3, 2016
@simonbrunel simonbrunel deleted the bower_release branch September 3, 2016 16:15
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Deploy dist files in release tags (bower support)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants