-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower Support Dropped, no dist folder #3081
Comments
Are you using the npm resolver as mentioned in the docs? |
In repository disappeared folder dist |
Yes I am using the npm resolver as described in the docs. |
@stephenHartzell reasons explained in this comment. Can you post your bower.json configuration file, and also the content of the chart.js package. I just checked, and dist files should be there. |
@simonbrunel here's my bower.json: "dependencies": {
"angular": "^1.5.8",
"angular-route": "^1.5.8",
"angular-animate": "^1.5.8",
"jquery": "^3.1.0",
"bootstrap": "^3.3.7",
"angular-bootstrap": "^1.3.3",
"angular-chart.js": "^1.0.0",
"angular-scroll": "^1.0.0",
"chart.js": "npm:chart.js#^2.2.1"
},
"resolutions": {
"jquery": "^3.1.0"
} Here's my .bowerrc file: {
"resolvers": [
"bower-npm-resolver"
]
} Starting from scratch (i.e. no {
"name": "Chart.js",
"homepage": "https://github.com/nnnick/Chart.js",
"version": "2.2.1",
"_release": "2.2.1",
"_resolution": {
"type": "version",
"tag": "v2.2.1",
"commit": "ab66146013a6b7c687630b414ba8731a6f25337c"
},
"_source": "https://github.com/nnnick/Chart.js.git",
"_target": "2.x"
}_source": "npm:chart.js",
"_target": "2.2.1",
"_release": "2.2.1",
"version": "2.2.1"
} Note the bad syntax at The work around, is to delete the chart.js folder and then run |
So do you mean it works if no previous version was installed? Looks like bower-npm-resolver messes up if there is already a version installed from a GH repository. If so, we should add that in the documentation. |
That's not quite what I mean. It'd probably be easiest for you to see it or yourself. If you grab that bower.json and run |
That's also kind of a breaking change, which breaks build since it does not respect the semver standard. |
@stephenHartzell: I think there is a conflict with the |
I have been usign Chart.js and angular-chart.js in a Rails project for some time. Went to deploy some updates to staging server and rake bower install is failing on this issue. No longer a Chart.js file at the project root or a dist dir. |
@simonbrunel this has been fixed in jtblin/angular-chart.js#453 merged a few days ago. @pelted you need to use |
Hi Why we can't use the old way anymore? |
same issue |
@sina-mirhejazi @MiszczProgramowania, bower should not try to access the git repository with this method. Also, the reported URL is weird, https://github.com/centralway/chart.js.git doesn't exist and I don't think that centralway has something to do with Chart.js (@etimberg, @tannerlinsley, @zachpanz88 ?). Did you guys followed exactly the doc instructions? |
Because of bower chart.js repository not found, i had problem with install other bower packages |
This looks like a duplicate of #3033 |
Fixed in version 2.3.0, no need to use |
@jtblin looks like you will need to revert your bower-npm-resolver change :\ |
I'm not sure why bower was dropped but the bower install is not sufficient as it does not include a dist folder minified chart.js files or the bundles. Furthermore, I get all a conflict when I also have angular-chart.js in my bower file. The two different chart entries in my bower file clobber eachother and end up removing the dist folder.
The text was updated successfully, but these errors were encountered: