Make dataflow graph correct with respect to pipes and FIFOs #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmoniumQ
force-pushed
the
pipe-correctness
branch
from
13265a3 to
4aff53c
Compare
charmoniumQ
force-pushed
the
pipe-correctness
branch
from
4aff53c to
4ed338f
Compare
charmoniumQ
added a commit
that referenced
this pull request
Aug 20, 2025
- Non-fatal errors are demoted to warnings. - Warnings will trigger failure when `--strict` is given (opposite of `--loose`), which is assumed by default. - Tests will have to give `--loose` until we merge in a better algorithm for dealing with pipes (#146).
charmoniumQ
added a commit
that referenced
this pull request
Aug 20, 2025
charmoniumQ
added a commit
that referenced
this pull request
Aug 20, 2025
charmoniumQ
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probe_pyahead of #146 #156