Made the boot server work again #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reference: They get logged to /tmp/qemu.log.
I believe these should be =m. Historically, these have been =g, but it got changed in 6a4457d or similar. Let's hope it works better now.
| @@ -192,7 +192,7 @@ static inline return_type system_call_memory_reserve(address_type start, unsigne | |||
| "pushl %4\n" | |||
| "lcall %5, $0" | |||
| : "=a" (return_value), | |||
| "=ri" (*virtual_address) | |||
| "=m" (*virtual_address) | |||
| : "ri" (virtual_address), | |||
| "ri" (size), | |||
| "ri" (start), | |||
There was a problem hiding this comment.
This is the critical part: fixing the asm constraints.
perlun
added a commit
that referenced
this pull request
May 21, 2015
…again Made the boot server work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The critical part here is the change in system_calls.h; the boot server was never really at fault, but it triggered an exception in the vga server. 😄