Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface tension model for phase change #904

Merged
merged 9 commits into from
Oct 14, 2023

Conversation

hepap
Copy link
Collaborator

@hepap hepap commented Oct 12, 2023

Description of the problem

  • Surface tension force was applied everywhere when treating solid-liquid phase change. This caused strange behaviour at the solid-liquid interface

Description of the solution

  • a surface tension model was added to compute the surface tension coefficient as: sigma=alpha_l*(sigma_0+dsigmadt*(T-T_0)), where alpha_l is the liquid fraction

How Has This Been Tested?

  • 2 tests added

  • solid_thermocapillary_droplet

  • liquid_thermocapillary_droplet.prm

Documentation

  • The documentation was updated

  • doc/source/parameters/cfd/physical_properties.rst

Future changes

  • none for now

Comments

  • nothing to add :)

Copy link
Collaborator

@PierreLaurentinCS PierreLaurentinCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Nothing more than a few typos

doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Outdated Show resolved Hide resolved
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
include/core/surface_tension_model.h Show resolved Hide resolved
@blaisb blaisb merged commit dc6d375 into master Oct 14, 2023
13 checks passed
@blaisb blaisb deleted the surface_tension_model_for_phase_change branch October 15, 2023 00:40
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description of the problem
Surface tension force was applied everywhere when treating solid-liquid phase change. This caused strange behaviour at the solid-liquid interface

Description of the solution
a surface tension model was added to compute the surface tension coefficient as: sigma=alpha_l*(sigma_0+dsigmadt*(T-T_0)), where alpha_l is the liquid fraction

How Has This Been Tested?
2 tests added

Former-commit-id: dc6d375
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description of the problem
Surface tension force was applied everywhere when treating solid-liquid phase change. This caused strange behaviour at the solid-liquid interface

Description of the solution
a surface tension model was added to compute the surface tension coefficient as: sigma=alpha_l*(sigma_0+dsigmadt*(T-T_0)), where alpha_l is the liquid fraction

How Has This Been Tested?
2 tests added

Former-commit-id: dc6d375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants