Add time average temperature and time average heat flux to simulation output #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivaia
added
Enhancement
mivaia
added
Ready for review
and removed
WIP
blaisb
requested changes
Dec 11, 2024
Comment on lines
+138
to
+140
| input >> buffer >> dt_0; | ||
| input >> buffer >> average_calculation; | ||
| input >> buffer >> real_initial_time; | ||
|
|
There was a problem hiding this comment.
We could use boost serialize for this but since we don't do it for the average velocity, what I would is open an issue, leave this PR as-is, and eventually migrate veerything to boost serialize. Although @lpsaavedra and I we had some issue with boost recently for unknown reasons.
blaisb
approved these changes
Dec 13, 2024
…dding it to the heat transfer physics
…e. Add preliminary code for the read_checkpoint function to consider the averaged scalars in the restarts. Code was not tested yet.
…rage temperature calculations. Modify a variable name and initial_time -> initial_time_for_average_velocity and all the files in which it was present.
… in heat_transfer.cc.
…sfer.cc. Add a test to check if average is computed properly
…e_average_temp_and_hf
…e heat flux is now outputed before initial_time_for_average_temperature_and_heat_flux
blaisb
force-pushed
the
add_average_heat_flux_in_post_processing
branch
from
c8c9a29 to
6fe6a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Time averaged temperature can now be attached to the vtus using a new parameter in the post-processing subsection.
A new object AverageScalarInTime has been created. It can be used to calculate the time average temperature from a certain point in time. This object is greatly inspired by the AverageVelocity object in postprocessing_velocity.h.
The average heat transfer is then computed using the computed average temperature and the HeatFluxPostProcessor object.
Testing
Two new tests have been added.
Documentation
Post processing subsection has been modified ta take into account the new parameter. The two new parameters are
calculate average temperature and average heat flux = true
initial time for average temperature and average heat flux = 0.0
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: