Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vof examples #1390

Merged
merged 19 commits into from
Nov 29, 2024
+1,685 −3,874
Merged

Update vof examples #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cf006c1
Add copy button
AmishgaAlphonius Nov 4, 2024
3ce3297
Update 2d dam break
AmishgaAlphonius Nov 20, 2024
0b6602b
Update refinement image
AmishgaAlphonius Nov 20, 2024
f1697a6
Update configuration figure
AmishgaAlphonius Nov 20, 2024
8100126
Update postprocessing file
AmishgaAlphonius Nov 20, 2024
10d1264
Update parameters files
AmishgaAlphonius Nov 20, 2024
49b2bd8
Remove DCDD in air-bubble-compression
AmishgaAlphonius Nov 22, 2024
5f83a5e
Remove square in dcdd term
AmishgaAlphonius Nov 25, 2024
aa542d6
Update air bubble compression example
AmishgaAlphonius Nov 25, 2024
8b816a2
Update rayleigh-taylor example
AmishgaAlphonius Nov 26, 2024
82db129
Update capillary wave example parameter files
AmishgaAlphonius Nov 26, 2024
c056be6
Update rayleigh-taylor example
AmishgaAlphonius Nov 26, 2024
1808bee
Update examples
AmishgaAlphonius Nov 26, 2024
fee2a46
Update capillary wave example
AmishgaAlphonius Nov 27, 2024
22aef30
Update change log
AmishgaAlphonius Nov 28, 2024
6cabc1a
Update sloshing example
AmishgaAlphonius Nov 28, 2024
6bc142a
Update application tests
AmishgaAlphonius Nov 28, 2024
f3fdd1e
Apply suggestions from review
AmishgaAlphonius Nov 28, 2024
b501c8f
correct time-step typos
AmishgaAlphonius Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
All notable changes to the Lethe project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/).

## [Master] - 2024-11-28

### Changed

- MINOR The squared term that was added in the correction direction vector of the VOF DCDD stabilization [#1103](https://github.com/chaos-polymtl/lethe/pull/1103) has been removed after observing regression in computed results of VOF examples. [#1390](https://github.com/chaos-polymtl/lethe/pull/1390)

## [Master] - 2024-11-21

### Changed
Expand Down
32 changes: 16 additions & 16 deletions applications_tests/lethe-fluid/gls_droplet_marangoni_effect.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,35 @@ Running on 1 MPI rank(s)...
Volume of triangulation: 0.0064
Number of thermal degrees of freedom: 4225
Number of VOF degrees of freedom: 4225
Enstrophy : 0
Kinetic energy : 0
Enstrophy: 0
Kinetic energy: 0

*******************************************************************************
Transient iteration: 1 Time: 0.001 Time step: 0.001 CFL: 0
Transient iteration: 1 Time: 0.001 Time step: 0.001 CFL: 0
*******************************************************************************
Enstrophy : 0.42658
Kinetic energy : 1.5988e-05
Enstrophy: 0.42658
Kinetic energy: 1.5988e-05

********************************************************************************
Transient iteration: 2 Time: 0.002 Time step: 0.001 CFL: 0.0080812
********************************************************************************
Enstrophy : 97.119
Kinetic energy : 0.0010102
Enstrophy: 97.103
Kinetic energy: 0.001011

*******************************************************************************
Transient iteration: 3 Time: 0.003 Time step: 0.001 CFL: 0.17532
Transient iteration: 3 Time: 0.003 Time step: 0.001 CFL: 0.17531
*******************************************************************************
Enstrophy : 299.29
Kinetic energy : 0.0039173
Enstrophy: 299.47
Kinetic energy: 0.0039228

*******************************************************************************
Transient iteration: 4 Time: 0.004 Time step: 0.001 CFL: 0.30998
Transient iteration: 4 Time: 0.004 Time step: 0.001 CFL: 0.31002
*******************************************************************************
Enstrophy : 513.69
Kinetic energy : 0.0079426
Enstrophy: 513.9
Kinetic energy: 0.0079503

*******************************************************************************
Transient iteration: 5 Time: 0.005 Time step: 0.001 CFL: 0.40316
Transient iteration: 5 Time: 0.005 Time step: 0.001 CFL: 0.40314
*******************************************************************************
Enstrophy : 705.36
Kinetic energy : 0.012344
Enstrophy: 705.51
Kinetic energy: 0.012354
Comment on lines +19 to +38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and it went back to the same values as before the square DCDD

2 changes: 1 addition & 1 deletion applications_tests/lethe-fluid/gls_vof_1_isothermal_compressible_fluid.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ Transient iteration: 2 Time: 0.2 Time step: 0.1 CFL: 1.64181
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.000000e-01 6.579242e-01 7.895070e-01 -2.229965e-02 4.765510e-02 3.420758e-01 3.420758e+02 1.863059e+01 -4.003717e+01 5.000000e-01
2.000000e-01 6.579141e-01 7.894950e-01 -2.231310e-02 4.763344e-02 3.420859e-01 3.420859e+02 1.864223e+01 -4.002050e+01 5.000000e-01
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but not this one :o

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to check them! :)
The values changed a bit with the fix on the pressure interpolation on faces (#1234) and we can see that the values remain somewhat similar to the ones that are overwritten.

2 changes: 1 addition & 1 deletion applications_tests/lethe-fluid/gls_vof_2_isothermal_compressible_fluids.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ Transient iteration: 2 Time: 0.2 Time step: 0.1 CFL: 1.53178
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.000000e-01 6.579652e-01 7.895557e-01 -2.004270e-02 4.448404e-02 3.420348e-01 1.710176e+01 8.361416e-01 -1.863500e+00 5.000000e-01
2.000000e-01 6.579587e-01 7.895478e-01 -2.005946e-02 4.446851e-02 3.420413e-01 1.710209e+01 8.365478e-01 -1.862997e+00 5.000000e-01
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nor this one! The rest of the application tests returned to their previous values (before the square)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here :)

26 changes: 13 additions & 13 deletions applications_tests/lethe-fluid/gls_vof_dirichlet_boundary_condition.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,44 +18,44 @@ Transient iteration: 1 Time: 0.05 Time step: 0.05 CFL: 2.23662
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
5.000000e-02 2.023368e-02 2.023368e+00 -2.916883e-03 -2.022545e+00 9.797663e-01 2.939299e+02 3.285580e-03 -2.938668e+02 5.000000e-01
5.000000e-02 2.022997e-02 2.022997e+00 -2.904127e-03 -2.022178e+00 9.797700e-01 2.939310e+02 3.247343e-03 -2.938679e+02 5.000000e-01

*******************************************************************************
Transient iteration: 2 Time: 0.1 Time step: 0.05 CFL: 2.93874
Transient iteration: 2 Time: 0.1 Time step: 0.05 CFL: 2.93873
*******************************************************************************

----------------------
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
1.000000e-01 3.991214e-02 3.991214e+00 -3.514015e-03 -3.993601e+00 9.600879e-01 2.880264e+02 3.315622e-03 -2.880185e+02 5.000000e-01
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
1.000000e-01 4.000801e-02 4.000801e+00 -3.499492e-03 -4.003198e+00 9.599920e-01 2.879976e+02 3.271545e-03 -2.879897e+02 5.000000e-01

*******************************************************************************
Transient iteration: 3 Time: 0.15 Time step: 0.05 CFL: 2.87622
Transient iteration: 3 Time: 0.15 Time step: 0.05 CFL: 2.87622
*******************************************************************************

----------------------
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
1.500000e-01 6.362990e-02 6.362990e+00 -3.677075e-03 -6.366046e+00 9.363701e-01 2.809110e+02 3.288925e-03 -2.809018e+02 5.000000e-01
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
1.500000e-01 6.365731e-02 6.365731e+00 -3.662590e-03 -6.368794e+00 9.363427e-01 2.809028e+02 3.244410e-03 -2.808936e+02 5.000000e-01

*******************************************************************************
Transient iteration: 4 Time: 0.2 Time step: 0.05 CFL: 2.86088
Transient iteration: 4 Time: 0.2 Time step: 0.05 CFL: 2.86088
*******************************************************************************

----------------------
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.000000e-01 8.856688e-02 8.856688e+00 -3.716378e-03 -8.860082e+00 9.114331e-01 2.734299e+02 2.660659e-03 -2.734197e+02 5.000000e-01
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.000000e-01 8.852284e-02 8.852284e+00 -3.702138e-03 -8.855684e+00 9.114772e-01 2.734431e+02 2.617015e-03 -2.734329e+02 5.000000e-01

*******************************************************************************
Transient iteration: 5 Time: 0.25 Time step: 0.05 CFL: 2.85364
Transient iteration: 5 Time: 0.25 Time step: 0.05 CFL: 2.85365
*******************************************************************************

----------------------
VOF Mass Conservation
----------------------
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.500000e-01 1.138431e-01 1.138431e+01 -3.712321e-03 -1.138794e+01 8.861569e-01 2.658471e+02 1.672484e-03 -2.658361e+02 5.000000e-01
time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold
2.500000e-01 1.137550e-01 1.137550e+01 -3.698586e-03 -1.137913e+01 8.862450e-01 2.658735e+02 1.630379e-03 -2.658626e+02 5.000000e-01
72 changes: 36 additions & 36 deletions applications_tests/lethe-fluid/gls_vof_ht_adapt-dissipation.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,52 +8,52 @@ Running on 1 MPI rank(s)...
*******************************************************************************
Transient iteration: 1 Time: 0.02 Time step: 0.02 CFL: 1.11831
*******************************************************************************
L2 error velocity : 0.99151
L2 error velocity: 0.99151
L2 error temperature : 4.95887e-13
L2 error phase : 0.00279114

*******************************************************************************
Transient iteration: 2 Time: 0.04 Time step: 0.02 CFL: 1.25786
Transient iteration: 2 Time: 0.04 Time step: 0.02 CFL: 1.25786
*******************************************************************************
L2 error velocity : 1.09115
L2 error temperature : 4.68382e-12
L2 error phase : 0.00284754
L2 error velocity: 1.091
L2 error temperature : 4.73269e-12
L2 error phase : 0.00286026

*******************************************************************************
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 1.28682
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 1.28679
*******************************************************************************
L2 error velocity : 1.12524
L2 error temperature : 2.14831e-11
L2 error phase : 0.00292325
L2 error velocity: 1.12496
L2 error temperature : 2.16659e-11
L2 error phase : 0.00295017

*******************************************************************************
Transient iteration: 4 Time: 0.08 Time step: 0.02 CFL: 1.29512
Transient iteration: 4 Time: 0.08 Time step: 0.02 CFL: 1.29508
*******************************************************************************
L2 error velocity : 1.13541
L2 error temperature : 6.41882e-11
L2 error phase : 0.00301194
L2 error velocity: 1.13507
L2 error temperature : 6.43194e-11
L2 error phase : 0.00305334

*******************************************************************************
Transient iteration: 5 Time: 0.1 Time step: 0.02 CFL: 1.2975
*******************************************************************************
L2 error velocity : 1.137
L2 error temperature : 1.43343e-10
L2 error phase : 0.0031096
time error_velocity error_pressure
0.0200 9.915105e-01 12.1545
0.0400 1.091154e+00 11.7510
0.0600 1.125244e+00 11.6955
0.0800 1.135406e+00 11.8167
0.1000 1.136995e+00 11.9363
cells error_temperature
256 4.958868e-13
256 4.683819e-12
256 2.148313e-11
256 6.418823e-11
256 1.433433e-10
time error_phase
0.0200 2.791137e-03
0.0400 2.847543e-03
0.0600 2.923250e-03
0.0800 3.011940e-03
0.1000 3.109602e-03
Transient iteration: 5 Time: 0.1 Time step: 0.02 CFL: 1.29745
*******************************************************************************
L2 error velocity: 1.13666
L2 error temperature : 1.42948e-10
L2 error phase : 0.00316573
time error_velocity error_pressure
0.0200 9.915105e-01 12.1545
0.0400 1.091004e+00 11.7602
0.0600 1.124961e+00 11.7061
0.0800 1.135072e+00 11.8248
0.1000 1.136664e+00 11.9419
cells error_temperature
256 4.958868e-13
256 4.732688e-12
256 2.166589e-11
256 6.431939e-11
256 1.429483e-10
time error_phase
0.0200 2.791137e-03
0.0400 2.860260e-03
0.0600 2.950171e-03
0.0800 3.053344e-03
0.1000 3.165733e-03
32 changes: 16 additions & 16 deletions applications_tests/lethe-fluid/gls_vof_hydrostat_initial_refine.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Running on 1 MPI rank(s)...
*******************************************************************************
Transient iteration: 1 Time: 0.02 Time step: 0.02 CFL: 0
*******************************************************************************
L2 error velocity : 1.09509e-07
L2 error velocity: 1.09509e-07
L2 error phase : 0.000174446

**********************************************************************************
Expand All @@ -57,23 +57,23 @@ Transient iteration: 2 Time: 0.04 Time step: 0.02 CFL: 7.71695e-0
Number of degrees of freedom: 6948
Volume of triangulation: 1
Number of VOF degrees of freedom: 2316
L2 error velocity : 1.09511e-07
L2 error phase : 0.000174449
L2 error velocity: 1.0951e-07
L2 error phase : 0.000174451

**********************************************************************************
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 7.71707e-06
**********************************************************************************
********************************************************************************
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 7.717e-06
********************************************************************************
Number of active cells: 2032
Number of degrees of freedom: 6948
Volume of triangulation: 1
Number of VOF degrees of freedom: 2316
L2 error velocity : 1.0951e-07
L2 error phase : 0.000174452
time error_velocity error_pressure
0.0200 1.095089e-07 0.0028
0.0400 1.095107e-07 0.0028
0.0600 1.095098e-07 0.0028
time error_phase
0.0200 1.744461e-04
0.0400 1.744490e-04
0.0600 1.744518e-04
L2 error velocity: 1.09508e-07
L2 error phase : 0.000174457
time error_velocity error_pressure
0.0200 1.095089e-07 0.0028
0.0400 1.095098e-07 0.0028
0.0600 1.095081e-07 0.0028
time error_phase
0.0200 1.744461e-04
0.0400 1.744515e-04
0.0600 1.744569e-04
52 changes: 26 additions & 26 deletions applications_tests/lethe-fluid/gls_vof_hydrostat_mesh-adapt.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Running on 1 MPI rank(s)...
*******************************************************************************
Transient iteration: 1 Time: 0.02 Time step: 0.02 CFL: 0
*******************************************************************************
L2 error velocity : 1.98025e-05
L2 error velocity: 1.98025e-05
L2 error phase : 0.0104167

**********************************************************************************
Expand All @@ -17,47 +17,47 @@ Transient iteration: 2 Time: 0.04 Time step: 0.02 CFL: 6.16399e-0
Number of degrees of freedom: 1596
Volume of triangulation: 1
Number of VOF degrees of freedom: 532
L2 error velocity : 3.09853e-06
L2 error phase : 0.00425559
L2 error velocity: 3.0985e-06
L2 error phase : 0.0042558

**********************************************************************************
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 1.63314e-05
**********************************************************************************
*********************************************************************************
Transient iteration: 3 Time: 0.06 Time step: 0.02 CFL: 1.6332e-05
*********************************************************************************
Number of active cells: 400
Number of degrees of freedom: 1437
Volume of triangulation: 1
Number of VOF degrees of freedom: 479
L2 error velocity : 2.63133e-06
L2 error phase : 0.00425566
L2 error velocity: 2.63119e-06
L2 error phase : 0.00425592

**********************************************************************************
Transient iteration: 4 Time: 0.08 Time step: 0.02 CFL: 1.41975e-05
Transient iteration: 4 Time: 0.08 Time step: 0.02 CFL: 1.41952e-05
**********************************************************************************
Number of active cells: 568
Number of degrees of freedom: 1950
Volume of triangulation: 1
Number of VOF degrees of freedom: 650
L2 error velocity : 2.06792e-06
L2 error phase : 0.00425573
L2 error velocity: 2.06779e-06
L2 error phase : 0.00425606

**********************************************************************************
Transient iteration: 5 Time: 0.1 Time step: 0.02 CFL: 1.31728e-05
Transient iteration: 5 Time: 0.1 Time step: 0.02 CFL: 1.31716e-05
**********************************************************************************
Number of active cells: 952
Number of degrees of freedom: 3300
Volume of triangulation: 1
Number of VOF degrees of freedom: 1100
L2 error velocity : 1.55492e-06
L2 error phase : 0.0042558
time error_velocity error_pressure
0.0200 1.980252e-05 0.0684
0.0400 3.098533e-06 0.0668
0.0600 2.631326e-06 0.0669
0.0800 2.067917e-06 0.0669
0.1000 1.554917e-06 0.0669
time error_phase
0.0200 1.041667e-02
0.0400 4.255591e-03
0.0600 4.255663e-03
0.0800 4.255733e-03
0.1000 4.255803e-03
L2 error velocity: 1.55472e-06
L2 error phase : 0.00425618
time error_velocity error_pressure
0.0200 1.980252e-05 0.0684
0.0400 3.098495e-06 0.0668
0.0600 2.631190e-06 0.0669
0.0800 2.067786e-06 0.0669
0.1000 1.554718e-06 0.0669
time error_phase
0.0200 1.041667e-02
0.0400 4.255796e-03
0.0600 4.255924e-03
0.0800 4.256056e-03
0.1000 4.256177e-03
Loading