Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pressure interpolation at face bug and other bugs #1234

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 8, 2024

Description

The new deal.II changes (more asserts) identified a nasty bug we had. The wong fe_values was being used to gather the pressure at the faces. Instead of the fe_face_values it was the fe_values. Consequently, I am really not sure what was happening there. This is now fixed.

Furthermore, there were also instances where the quadrature of the fluid dynamics in the VOF solver was not initialized with the right number of points. This has been fixed also.

Testing

Tests that were breaking in debug should work just fine now in debug.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb changed the title Fix pressure interpolation at face bug Fix pressure interpolation at face bug and other bugs Aug 8, 2024
@blaisb blaisb merged commit 60c5f97 into master Aug 8, 2024
8 checks passed
@blaisb blaisb deleted the fix_debug_ci branch August 8, 2024 16:04
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
…1234)

Description
The new deal.II changes (more asserts) identified a nasty bug we had. The wong fe_values was being used to gather the pressure at the faces. Instead of the fe_face_values it was the fe_values. Consequently, I am really not sure what was happening there. This is now fixed.

Furthermore, there were also instances where the quadrature of the fluid dynamics in the VOF solver was not initialized with the right number of points. This has been fixed also.

Testing
Tests that were breaking in debug should work just fine now in debug.

Former-commit-id: 60c5f97
blaisb added a commit that referenced this pull request Sep 30, 2024
Description
The new deal.II changes (more asserts) identified a nasty bug we had. The wong fe_values was being used to gather the pressure at the faces. Instead of the fe_face_values it was the fe_values. Consequently, I am really not sure what was happening there. This is now fixed.

Furthermore, there were also instances where the quadrature of the fluid dynamics in the VOF solver was not initialized with the right number of points. This has been fixed also.

Testing
Tests that were breaking in debug should work just fine now in debug.

Former-commit-id: 60c5f97
@AmishgaAlphonius AmishgaAlphonius mentioned this pull request Nov 28, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants