Encapsulation of the load balancing in DEM and CFD-DEM #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdaigneault
added
Refactoring
blaisb
reviewed
Jul 19, 2024
examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.prm
Outdated
Show resolved
Hide resolved
blaisb
reviewed
Jul 19, 2024
blaisb
reviewed
Jul 19, 2024
Comment on lines
+376
to
+456
| /** | ||
| * @brief Pointer to the simulation control object. | ||
| */ | ||
| std::shared_ptr<SimulationControl> simulation_control; | ||
|
|
||
| /** | ||
| * @brief Pointer to the triangulation object. | ||
| */ | ||
| parallel::distributed::Triangulation<dim> *triangulation; | ||
|
|
||
| /** | ||
| * @brief Pointer to the particle handler object. | ||
| */ | ||
| Particles::ParticleHandler<dim> *particle_handler; | ||
|
|
||
| /** | ||
| * @brief Pointer to the adaptive sparse contacts object. | ||
| */ | ||
| AdaptiveSparseContacts<dim> *adaptive_sparse_contacts; |
There was a problem hiding this comment.
Any reasons why you are keeping raw points for some stuff and shared_ptr for others?
I presume the one for which you are keeping raw points are not pointer in the DEM class, is that it?
blaisb
reviewed
Jul 19, 2024
acdaigneault
force-pushed
the
dem_encapsulate-load-balancing
branch
2 times, most recently
from
6980bec to
d6f5b2e
Compare
voferreira
approved these changes
Jul 19, 2024
applications_tests/lethe-fluid-particles/spouted_bed_load_balancing.prm
Outdated
Show resolved
Hide resolved
I will look into the failling test this PM, probably the rayleigh ratio :) |
Yes because the test failed after rebased |
Move the cell weight in the class
Make compatible the prm generator for easy restart generation
Output is still the same as fixed master
acdaigneault
force-pushed
the
dem_encapsulate-load-balancing
branch
from
e61262c to
a08b710
Compare
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…#1199) Description The functions related to the load balancing were implemented in the DEM solver and coupling CFD-DEM solver even tho it is not really specific to the solvers. The setup and the routine were duplicated in both solvers, making modifications or maintenances harder. The solution is the implementation the load balancing class with mostly the same functions. The load balancing is also fixed for the CFD-DEM. It was not working since nov. 2022, oops. Testing All tests related to the load balacing in DEM are still passing. A new test spouted_bed_load_balancing_generator.prm was added for the unresolved cfd-dem tests. After a quick fix on the master, results were compared and are the same. Former-commit-id: 2e3dfc0
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The functions related to the load balancing were implemented in the DEM solver and coupling CFD-DEM solver even tho it is not really specific to the solvers. The setup and the routine were duplicated in both solvers, making modifications or maintenances harder. The solution is the implementation the load balancing class with mostly the same functions. The load balancing is also fixed for the CFD-DEM. It was not working since nov. 2022, oops. Testing All tests related to the load balacing in DEM are still passing. A new test spouted_bed_load_balancing_generator.prm was added for the unresolved cfd-dem tests. After a quick fix on the master, results were compared and are the same. Former-commit-id: 2e3dfc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functions related to the load balancing were implemented in the DEM solver and coupling CFD-DEM solver even tho it is not really specific to the solvers.
The setup and the routine were duplicated in both solvers, making modifications or maintenances harder.
The solution is the implementation the load balancing class with mostly the same functions.
The load balancing is also fixed for the CFD-DEM. It was not working since nov. 2022, oops.
Testing
All tests related to the load balacing in DEM are still passing.
A new test
spouted_bed_load_balancing_generator.prmwas added for the unresolved cfd-dem tests.After a quick fix on the master, results were compared and are the same.
Miscellaneous (will be removed when merged)
It is not fully encapsulated (the load_balance() functions are still implemented in the solvers), but it is the cleanest and easier way to do it to this day with the way the code flags some step (load_balancing, checkpoint, etc...) and executes reinititialization and other stuff.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: