Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Tooltip): add testing thresholds to tooltip snaps #1617

Merged
merged 7 commits into from
May 17, 2023
+135 −285
Merged

test(Tooltip): add testing thresholds to tooltip snaps #1617

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8bf2bf
test(Tooltip): add testing thresholds to tooltip snaps
booc0mtaco May 16, 2023
0b23679
chore: reduce from 0.8 to 0.25
booc0mtaco May 16, 2023
21055e4
chore: increase from 0.25 to 0.5
booc0mtaco May 16, 2023
5021998
chore: simplify implementation
booc0mtaco May 16, 2023
d2da5ab
chore: add spacing decorator
booc0mtaco May 16, 2023
65ef286
test(Slider): add diffThreshold for tooltip story
booc0mtaco May 17, 2023
c9fdb51
chore: adjust threshold to 0.75
booc0mtaco May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: reduce from 0.8 to 0.25
@booc0mtaco
booc0mtaco committed May 16, 2023
commit 0b2367905bc860c9d72860a0a9b790300ba55021
8 changes: 4 additions & 4 deletions src/components/Tooltip/Tooltip.stories.tsx
View file
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ export default {
chromatic: {
// diminishing the threshold of this component to avoid sub-pixel jittering
// https://www.chromatic.com/docs/threshold
diffThreshold: 0.8,
diffThreshold: 0.25,
diffIncludeAntiAliasing: false,
},
},
@@ -166,7 +166,7 @@ export const DisabledButton: StoryObj<Args> = {
chromatic: {
// diminishing the threshold of this component to avoid sub-pixel jittering
// https://www.chromatic.com/docs/threshold
diffThreshold: 0.8,
diffThreshold: 0.25,
diffIncludeAntiAliasing: false,
},
},
@@ -189,7 +189,7 @@ export const TextChild: StoryObj<Args> = {
chromatic: {
// diminishing the threshold of this component to avoid sub-pixel jittering
// https://www.chromatic.com/docs/threshold
diffThreshold: 0.8,
diffThreshold: 0.25,
diffIncludeAntiAliasing: false,
},
},
@@ -244,7 +244,7 @@ export const InteractiveDisabledButton: StoryObj<Args> = {
chromatic: {
// diminishing the threshold of this component to avoid sub-pixel jittering
// https://www.chromatic.com/docs/threshold
diffThreshold: 0.8,
diffThreshold: 0.25,
diffIncludeAntiAliasing: false,
},
},