test(Tooltip): add testing thresholds to tooltip snaps #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1617 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.01%
==========================================
Files 280 280
Lines 4195 4192 -3
Branches 789 789
==========================================
- Hits 3831 3828 -3
Misses 338 338
Partials 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
approved these changes
May 16, 2023
ahuth
reviewed
May 17, 2023
ahuth
reviewed
May 17, 2023
- this is based on looking at the interactive diff tool offered by chromatic - https://www.chromatic.com/docs/threshold
jinlee93
reviewed
Jun 6, 2023
| Tooltip trigger | ||
| </Button> | ||
| ), | ||
| children: <div className="fpo w-3 p-1">•</div>, |
There was a problem hiding this comment.
Sorry to re-dig this up. If we recall, why did we make the trigger a bullet? @booc0mtaco
There was a problem hiding this comment.
@jinlee93 no special reason. I was curious to see how HTML entities worked. confirmed it wouldn't escape the code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
From https://www.chromatic.com/docs/threshold, allow for more variance in the snapshots for
Tooltipinstead of disabling the tests. Also apply to any snapshots that use render directly. This should reduce the flakiness of some of these tests (and let us re-enable the tests that were turned off before)Test Plan:
(n/a) Verify whether this makes any difference to tests by re-running tests a few times