Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numpy 2 #1343

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Allow numpy 2 #1343

merged 5 commits into from
Mar 12, 2025

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jan 24, 2025

Fixes #1240

Unpinning numpy 2 since the test suite now runs fine with numpy 2.1.3.

@ivirshup ivirshup added the dependencies Pull requests that update a dependency file label Jan 24, 2025
@ivirshup ivirshup requested a review from ebezzi January 24, 2025 19:42
@ivirshup ivirshup marked this pull request as draft January 24, 2025 21:23
@ivirshup
Copy link
Collaborator Author

Hmm, that didn't fail so badly locally. Will investigate further

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (acfde71) to head (238b22f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   92.43%   91.94%   -0.49%     
==========================================
  Files          83       83              
  Lines        6739     6744       +5     
==========================================
- Hits         6229     6201      -28     
- Misses        510      543      +33     
Flag Coverage Δ
unittests 91.94% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ivirshup ivirshup marked this pull request as ready for review March 12, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support numpy 2
2 participants